Fix issue 1721 by always initializing process group. #1722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rpehkone
pushed a commit
to rpehkone/YOLOX-custom
that referenced
this pull request
Apr 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes issue #1721, where single GPU training/inference may error if the worker uses
torch.dist. In summary, it makes sure the default process group is always initialized as long asworld_size > 0, otherwise it raises aValueErrorto indicate illegal argument(s). The existing code should not be affected, as stated in issue #1721.Rationale: Always initializing the process group is preferred, because when
launchis called, the user most likely requests distributed semantics. This fix makes the user code consistent by allowing the users to maketorch.distcalls even if there is only one GPU.