[Traffic Control] Fully remove client IP param injection #17803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
bmwill
approved these changes
May 17, 2024
williampsmith
force-pushed
the
william/remove-ip-param-injection
branch
from
c955294
to
5e746bb
Compare
7 tasks
williampsmith
added a commit
that referenced
this pull request
May 20, 2024
This removes the plumbing to get client IP through json rpc requests by injecting into the request param. Things NOT touched: 1. Did not remove plumbing of the client IP from transaction orchestrator forward. This allows for us to later route client IP through other interfaces such as graphql, which has far bettewr support for such things. This is fine as these fields are all optional and should not change anything 2. We still accept and segment proxied requests in traffic control policies, again, so that other interfaces may forward and everything will work as before. Existing tests --- Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
7 tasks
williampsmith
added a commit
that referenced
this pull request
May 20, 2024
This removes the plumbing to get client IP through json rpc requests by injecting into the request param. Things NOT touched: 1. Did not remove plumbing of the client IP from transaction orchestrator forward. This allows for us to later route client IP through other interfaces such as graphql, which has far bettewr support for such things. This is fine as these fields are all optional and should not change anything 2. We still accept and segment proxied requests in traffic control policies, again, so that other interfaces may forward and everything will work as before. Existing tests --- Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
williampsmith
added a commit
that referenced
this pull request
May 20, 2024
This removes the plumbing to get client IP through json rpc requests by injecting into the request param. Things NOT touched: 1. Did not remove plumbing of the client IP from transaction orchestrator forward. This allows for us to later route client IP through other interfaces such as graphql, which has far bettewr support for such things. This is fine as these fields are all optional and should not change anything 2. We still accept and segment proxied requests in traffic control policies, again, so that other interfaces may forward and everything will work as before. Existing tests --- Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
williampsmith
added a commit
that referenced
this pull request
May 20, 2024
This removes the plumbing to get client IP through json rpc requests by injecting into the request param. Things NOT touched: 1. Did not remove plumbing of the client IP from transaction orchestrator forward. This allows for us to later route client IP through other interfaces such as graphql, which has far bettewr support for such things. This is fine as these fields are all optional and should not change anything 2. We still accept and segment proxied requests in traffic control policies, again, so that other interfaces may forward and everything will work as before. Existing tests --- Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
7 tasks
williampsmith
added a commit
that referenced
this pull request
May 20, 2024
This removes the plumbing to get client IP through json rpc requests by injecting into the request param. Things NOT touched: 1. Did not remove plumbing of the client IP from transaction orchestrator forward. This allows for us to later route client IP through other interfaces such as graphql, which has far bettewr support for such things. This is fine as these fields are all optional and should not change anything 2. We still accept and segment proxied requests in traffic control policies, again, so that other interfaces may forward and everything will work as before. Existing tests --- Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
williampsmith
added a commit
that referenced
this pull request
May 20, 2024
This removes the plumbing to get client IP through json rpc requests by injecting into the request param. Things NOT touched: 1. Did not remove plumbing of the client IP from transaction orchestrator forward. This allows for us to later route client IP through other interfaces such as graphql, which has far bettewr support for such things. This is fine as these fields are all optional and should not change anything 2. We still accept and segment proxied requests in traffic control policies, again, so that other interfaces may forward and everything will work as before. Existing tests --- Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
williampsmith
added a commit
that referenced
this pull request
May 20, 2024
This removes the plumbing to get client IP through json rpc requests by injecting into the request param. Things NOT touched: 1. Did not remove plumbing of the client IP from transaction orchestrator forward. This allows for us to later route client IP through other interfaces such as graphql, which has far bettewr support for such things. This is fine as these fields are all optional and should not change anything 2. We still accept and segment proxied requests in traffic control policies, again, so that other interfaces may forward and everything will work as before. Existing tests --- Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
williampsmith
added a commit
that referenced
this pull request
May 20, 2024
## Description CP the following PRs into 1.24: #17408 #17639 #17656 #17761 #17803 #17655 ## Test plan All logic in this PR is a revert, so just check that existing tests pass ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
williampsmith
added a commit
that referenced
this pull request
May 20, 2024
## Description CP the following PRs into 1.25: #17639 #17656 #17761 #17803 #17655 #17831 ## Test plan How did you test the new or updated feature? --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This removes the plumbing to get client IP through json rpc requests by injecting into the request param.
Things NOT touched:
Test plan
Existing tests
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.