[cherry-pick][graphql] Cherry pick windows build fix #17804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Description Fix `mysqlclient-sys` windows cargo build error ## Test plan https://github.com/MystenLabs/sui/actions/runs/8978802872/job/24659827747?pr=17538
|
@ebmifa is attempting to deploy a commit to the Mysten Labs Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ebmifa
approved these changes
May 17, 2024
|
I recall you mentioned somewhere that you were concerned about this pick because it failed simtest -- IIRC, this particular test is flaky, so it should be okay to land despite it failing. |
stefan-mysten
merged commit 7a4b28a
into
MystenLabs:releases/sui-graphql-rpc-v2024.4.0-release
39 of 44 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix
mysqlclient-syswindows cargo build errorTest plan
https://github.com/MystenLabs/sui/actions/runs/8978802872/job/24659827747?pr=17538