-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contrastive Reranker/Reward model #9171
Open
arendu
wants to merge
19
commits into
main
Choose a base branch
from
adithyare/embedding_reranking
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: arendu <adithya.r@gmail.com>
Signed-off-by: arendu <adithya.r@gmail.com>
Signed-off-by: arendu <adithya.r@gmail.com>
nemo/collections/nlp/models/information_retrieval/megatron_gpt_reranker_model.py
Fixed
Show resolved
Hide resolved
examples/nlp/information_retrieval/megatron_gpt_reranker_finetuning.py
Fixed
Show resolved
Hide resolved
Signed-off-by: arendu <adithya.r@gmail.com>
Signed-off-by: arendu <adithya.r@gmail.com>
Signed-off-by: arendu <adithya.r@gmail.com>
Signed-off-by: arendu <adithya.r@gmail.com>
Signed-off-by: arendu <arendu@users.noreply.github.com>
cuichenx
reviewed
May 13, 2024
examples/nlp/information_retrieval/megatron_gpt_reranker_finetuning.py
Fixed
Show resolved
Hide resolved
examples/nlp/information_retrieval/megatron_gpt_reranker_finetuning.py
Outdated
Show resolved
Hide resolved
examples/nlp/information_retrieval/megatron_gpt_reranker_generate.py
Outdated
Show resolved
Hide resolved
nemo/collections/nlp/models/information_retrieval/megatron_gpt_reranker_model.py
Outdated
Show resolved
Hide resolved
nemo/collections/nlp/models/information_retrieval/megatron_gpt_reranker_model.py
Fixed
Show resolved
Hide resolved
nemo/collections/nlp/models/information_retrieval/megatron_gpt_reranker_model.py
Outdated
Show resolved
Hide resolved
nemo/collections/nlp/models/information_retrieval/megatron_gpt_reranker_model.py
Show resolved
Hide resolved
nemo/collections/nlp/modules/common/megatron/adapters/mcore_mixins.py
Outdated
Show resolved
Hide resolved
nemo/collections/nlp/modules/common/megatron/adapters/parallel_adapters.py
Show resolved
Hide resolved
Signed-off-by: arendu <arendu@users.noreply.github.com>
Signed-off-by: arendu <arendu@users.noreply.github.com>
cuichenx
previously approved these changes
May 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cuichenx
reviewed
May 14, 2024
examples/nlp/information_retrieval/conf/megatron_gpt_embedder_tuning_config.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: arendu <adithya.r@gmail.com>
cuichenx
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
enables training of a contrastive reranker model based on GPT architecture and PEFT. Used for reranking the results of an embedding model.
Collection: [NLP]
Changelog
Usage
# Add a code snippet demonstrating how to use this
GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information