Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contrastive Reranker/Reward model #9171

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

Conversation

arendu
Copy link
Collaborator

@arendu arendu commented May 11, 2024

What does this PR do ?

enables training of a contrastive reranker model based on GPT architecture and PEFT. Used for reranking the results of an embedding model.

Collection: [NLP]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

arendu added 5 commits May 8, 2024 23:47
Signed-off-by: arendu <adithya.r@gmail.com>
Signed-off-by: arendu <adithya.r@gmail.com>
Signed-off-by: arendu <adithya.r@gmail.com>
Signed-off-by: arendu <adithya.r@gmail.com>
Signed-off-by: arendu <adithya.r@gmail.com>
Signed-off-by: arendu <adithya.r@gmail.com>
Signed-off-by: arendu <adithya.r@gmail.com>
@github-actions github-actions bot added the CI label May 11, 2024
Signed-off-by: arendu <adithya.r@gmail.com>
Signed-off-by: arendu <adithya.r@gmail.com>
@arendu arendu added Run CICD and removed Run CICD labels May 12, 2024
@arendu arendu added Run CICD and removed Run CICD labels May 12, 2024
Signed-off-by: arendu <arendu@users.noreply.github.com>
Signed-off-by: arendu <adithya.r@gmail.com>
@arendu arendu requested a review from cuichenx May 13, 2024 20:57
Signed-off-by: arendu <arendu@users.noreply.github.com>
@arendu arendu added Run CICD and removed Run CICD labels May 13, 2024
arendu and others added 2 commits May 14, 2024 16:48
Signed-off-by: arendu <adithya.r@gmail.com>
Signed-off-by: arendu <arendu@users.noreply.github.com>
cuichenx
cuichenx previously approved these changes May 14, 2024
Copy link
Collaborator

@cuichenx cuichenx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cuichenx cuichenx removed the Run CICD label May 14, 2024
Signed-off-by: arendu <adithya.r@gmail.com>
@arendu arendu added Run CICD and removed Run CICD labels May 15, 2024
@arendu arendu changed the title Contrastive Reranker model Contrastive Reranker/Reward model May 15, 2024
@arendu arendu added Run CICD and removed Run CICD labels May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants