Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Speeding NeMo-CI up by using caching #9174

Merged
merged 8 commits into from
May 16, 2024
Merged

Conversation

ko3n1g
Copy link
Collaborator

@ko3n1g ko3n1g commented May 12, 2024

What does this PR do ?

Build and use a dedicated CI container image to speed things up.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@github-actions github-actions bot added the CI label May 12, 2024
@ko3n1g ko3n1g force-pushed the ko3n1g/ci/add-dockerfile branch 5 times, most recently from 44b7e71 to 65799c4 Compare May 13, 2024 08:44
@ko3n1g ko3n1g changed the title dockerfile ci: Speeding NeMo-CI up by using caching May 13, 2024
@ko3n1g ko3n1g marked this pull request as ready for review May 13, 2024 08:46
Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
pablo-garay
pablo-garay previously approved these changes May 15, 2024
@pablo-garay
Copy link
Collaborator

Tests passed & seeing container build time faster than before:
https://github.com/NVIDIA/NeMo/actions/runs/9084110720/job/24972186694

reinstall.sh Outdated Show resolved Hide resolved
Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
@ko3n1g ko3n1g requested a review from ericharper May 16, 2024 07:07
Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
@ko3n1g ko3n1g added Run CICD and removed Run CICD labels May 16, 2024
Copy link
Collaborator

@thomasdhc thomasdhc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me, let's check that the cicd passes.

@ericharper ericharper merged commit 526b6ad into main May 16, 2024
132 checks passed
@ericharper ericharper deleted the ko3n1g/ci/add-dockerfile branch May 16, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants