-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Speeding NeMo-CI up by using caching #9174
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ko3n1g
force-pushed
the
ko3n1g/ci/add-dockerfile
branch
5 times, most recently
from
May 13, 2024 08:44
44b7e71
to
65799c4
Compare
Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
ko3n1g
force-pushed
the
ko3n1g/ci/add-dockerfile
branch
from
May 13, 2024 17:18
65799c4
to
79fd28a
Compare
pablo-garay
previously approved these changes
May 15, 2024
Tests passed & seeing container build time faster than before: |
ericharper
reviewed
May 15, 2024
Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
ko3n1g
force-pushed
the
ko3n1g/ci/add-dockerfile
branch
from
May 15, 2024 16:45
6523dd3
to
15e7537
Compare
Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
ko3n1g
force-pushed
the
ko3n1g/ci/add-dockerfile
branch
from
May 16, 2024 09:03
d8d329a
to
7422183
Compare
Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
ko3n1g
force-pushed
the
ko3n1g/ci/add-dockerfile
branch
from
May 16, 2024 12:05
632e363
to
e481407
Compare
thomasdhc
reviewed
May 16, 2024
thomasdhc
reviewed
May 16, 2024
thomasdhc
reviewed
May 16, 2024
Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
thomasdhc
approved these changes
May 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me, let's check that the cicd passes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Build and use a dedicated CI container image to speed things up.
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use this
GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information