Lhotse Sharding Fix #9187
Merged
Lhotse Sharding Fix #9187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pzelasko
reviewed
May 14, 2024
| f"Mismatched entry between JSON manifest ('{manifest_path}') and tar file ('{tar_path}'). " | ||
| f"Conflicting audio file names are JSON='{data['audio_filepath']}' and TAR='{tar_info.name}'" | ||
| f"Cannot locate manifest entry for TAR='{tar_info.name}'" |
There was a problem hiding this comment.
Suggested change
| f"Cannot locate manifest entry for TAR='{tar_info.name}'" | |
| f"Cannot locate JSON audio path '{data['audio_filepath']}' in tar file '{tar_info.name}'" |
It'd be better to mention which specific audio filepath is missing e.g. like this
There was a problem hiding this comment.
That won't work here since we're iterating through data first. It also isn't informative anymore since this doesn't enforce order.
Signed-off-by: Piotr Żelasko <petezor@gmail.com>
8 tasks
Signed-off-by: Travis Bartley <tbartley@nvidia.com>
Signed-off-by: tbartley94 <tbartley94@users.noreply.github.com>
pzelasko
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Caches manifest entries during
LazyNeMoTarredIteratorin Lhotse to avoid errors from improper sorting. Allows back compatibility with webdataset behavior.Collection: [Note which collection this PR will affect]
Changelog
GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information