-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NeMo-UX] Adding fn to nemo #9194
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: marcromeyn <marcromeyn@users.noreply.github.com>
Signed-off-by: Chen Cui <chcui@nvidia.com>
@@ -0,0 +1,81 @@ | |||
<<<<<<< HEAD:tests/collections/llm/fn/test_mixin.py |
Check failure
Code scanning / CodeQL
Syntax error Error
|
||
@runtime_checkable | ||
class HasBool(Protocol): | ||
def __bool__(self) -> bool: ... |
Check notice
Code scanning / CodeQL
Statement has no effect Note
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Freeze and Unfreeze are already part of NeuralModule, which ModelPT inherits.
The models inside the new llm collection are not using ModelPT as a base class |
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use this
GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information