-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor WindowOtherWheelInput to be safer and script window compatible #22060
Refactor WindowOtherWheelInput to be safer and script window compatible #22060
Conversation
@Basssiiie I believe I've addressed the issues with the two latest commits. Due to how the FlexUI's DropdownSpinnerControl works, the label does not support scrolling, unfortunately. However, the [-][+] spinner buttons work as expected for me. Adding scrollwheel support to dropdown widgets should be possible as well, though. That will require a new codepath, though, and is therefore best left to another PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested it again and I have found no further issues. It all looks good to me now. Thanks!
And yeah don't worry, I don't expect the dropdowns to work here. It's a custom set up anyway and I'm already happy the [+]
/[-]
now work as expected. 😃
020c1bf
to
10c97c6
Compare
We've been able to use the mouse scroll wheel to manipulate spinner widgets for years (#7627). However, the function that was added in to support this had not been updated to account for custom (script) windows.
This PR ports the algorithm from OpenLoco/OpenLoco#2019, which is both (memory) safer as well as more accurate, making it compatible with spinner widgets in custom (script) windows.
Fixes Basssiiie/OpenRCT2-RideVehicleEditor#111