Replace assertions in DecodeChunkRLEWithSize() #22061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tupaschoal
reviewed
May 18, 2024
Gymnasiast
force-pushed
the
fix/crash-sawyercoding
branch
from
3dd361a
to
f01591c
Compare
tupaschoal
approved these changes
May 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the game tries to decode something as RLE that isn’t RLE, or is damaged, assertions might get hit, crashing the game.
Examples are #21393.
Replace these assertions with exceptions, so that the callers can take appropriate action (e.g. show an error message saying the file is corrupted).