[OpenCL]remove process_type to fix FP16 result error #10451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
engineer1109
requested review from
zhupengyang and
hong19860320
as code owners
|
Thanks for your contribution! |
|
yolov5_s复现模型 链接: https://pan.baidu.com/s/1xfv8A0LXm-6-Yk0wyq5sEA?pwd=tvbe 提取码: tvbe |
|
@hong19860320 CI已经年久失修了，连git clone的能力都没有 |
已经正在修了，git clone 失败是代理问题。 |
|
@engineer1109 从之前 tiantian 提的 PR 来看 #9688 ，可能是为了解决自定义 CPU GPU 异构时，在 h2d 过程中可以同步实现 fp32->fp16 的转换，可能实现考虑的不全。 |
|
空闲时间回忆了下当初的实现思路，大致如下，如#9688 所描述，为了支持更多的模型，支持cpu， opencl image2d, opencl buffer 混合layout，混合精度推理，可配置算子后端信息等，对iocopy， layout 等算子和pass做出了修改。对于yolo模型，之前未进行适配，可能存在精度问题，需进一步check |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR devices
OpenCL
PR types
Bug fixes
PR changes
OP
Description
之前离职员工tiantian留下的BUG。
对于某些特殊模型，会设置process_type为2, 禁止io_copy的FP16模式（触发机制和意义不明，会导致yolov5_s等推理结果出错）
导致FP16的Tensor，被当成FP32使用。精度混乱。
这里删除了 param.process_type != 2的判定条件。
强制在FP16模式，使用FP16的逻辑处理。