fix npu sft ckpt load bug and no FA bug #8438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #8438 +/- ##
===========================================
- Coverage 55.42% 55.42% -0.01%
===========================================
Files 617 617
Lines 96281 96286 +5
===========================================
+ Hits 53366 53367 +1
- Misses 42915 42919 +4 ☔ View full report in Codecov by Sentry. |
ZHUI
reviewed
May 15, 2024
llm/finetune_generation.py
Outdated
| model_config.attention_probs_dropout_prob = model_args.attention_probs_dropout_prob | ||
|
|
||
| model_config.sep_parallel_degree = training_args.sep_parallel_degree | ||
| model_config.tensor_parallel_output = True |
ZHUI
previously approved these changes
May 15, 2024
|
NINGBENZHE seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
Others
Description
fix npu sft ckpt load bug and no FA bug