Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement wisps support #7532

Open
wants to merge 9 commits into
base: dev
Choose a base branch
from

Conversation

Paliak
Copy link
Contributor

@Paliak Paliak commented Apr 2, 2024

Fixes #7524

Supersedes #7475

Description of the problem being solved:

Implements handling of Sacred Wisps Support.

Link to a build that showcases this PR:

eNq1G2tv4kjy8_ArLKSV7rQXHjaQEJFdkZBMkJIJB5nJ3adRYzfQO203Y7eTsKv971fdbRtDaGNjXyIlxl3v6qquKpvB7-8uNV6xHxDmXdXbjVbdwJ7NHOItr-pfn-_OLuq__1YbTBBfPS2uQ0LFym-1TwN5bVD8iing1Q2O_CXm32JK1negtEYeX2HmPaI_mP-ZOVf1L8zDdWOOPIfw-JNNURB8QS6-qs9sQK4bKLCx59xs70eAK-Qjm2P_QXAdhpw9MgdWuR_CqouIN2P2D8w_-yxcS6FeCX5TMOPHydP0OSUS8dIigUafBhOKNtifccSNAP5c1YdgGLTEI-TCX6CGaAikLlqNft9qmZ3z_kWvf15vZiJfh37AT6MwW2PsJEitxoWpg5z4-HaxwDYnr_jGJ_xmhTw7xa_R7ehQD4J3up1eFsJjSDlZU4L9BKndONcqcv-BRb-vg31mHNHRZJaA9nqNTrtjXrQsq9O32tl4jG_tpYN8IXx1TcG0J3ARuOOlRzg-EXnCSMC8EvqlUbUq3oSUQpymYc8b1nnf6nU6F-1eV2v9KQ6w_4o42ZVRz4i5c-LtmvLcauTgNOPbvWNq6Y_wew6oscdzQE3xzzRg--JCz_WVcZmJjukvvXJ7P0kgu_1Gu21ZrVanb_baWm9OVpuA2Ig-onfihi4EyDP6gbcMe1qOD2S54h44V4dqadW6Iz4ujnXDqHMC1gqxoDjaIyTxezgdhrYdQq7fJCidDIMscA67QTK1LwXs2LOP-1UAfvV8GQ2pHNzLRJhim4mkP6c4J8aWxQT7cOaldmfrCKsl9iJ-m3zqPGBsrz6DfaeI4-Moj8hD212dbVYBm8usAvCAWbs5EQoYSSBqjNToZyEVNNOth_3lZrYimDrFoGPBbtD6OKI0cxo7l7l32RXaMWnUgiZ5QX4OU0yhICoq0ysK0lm53cs2lwLPtzExFASA4OC9QqWlL7nYH6LgosXQhr7LQj-nwxVwLgXiA0VVmlPshHa-E-yaQs2cV3qQitJCGEPOkf1jxJwlLsSkEEZS-0rUWbheQ8YQvs9LQJyMUPqQYJtbzno5oJ9g4-aKX3GI5mewhc7NICkL8nPZQ8mvizjaCyizBc_NInHoI6QGF1K-bIWgk9vGvtY5UPrmKl0lYM56esLeQPKVaHGDYtBQAm3LHq0oPvb-3OSmvwOei8Gt50A5BaGQm8c-xiE2z8SFtBkEI8SR4UQ18zfkE-ixTdl_Bxj59uoBXH-HKJ1DJriqp-_KT7JnvyMUGvsR3BNMhWD7FNux0wdNOXsQV2N3zXxu4Hfxb4J8vrmqLxANsAKUd4BOwIknexrIR5TWjdmKvQ2dV8HpmTEaxEgGWq-x5-zQePYxNlCcXWwhhFRefDBcFIDUG7VdA6FNanQxdqQaHgMBoMa5uLAsobvNPAf5m-EuoEdALg68UhMUsxMNRxQlwfbT4Ov0QV58WnG-Di6bzbe3t8Ya8RVb4Hc4jRo2c5trQAKBz4IfhNIzQbY5hJ_r5VD-SELNmNJATU2CpvokgtQnILNyclMoKq0uLCEuvjCOA7EmbsYfBjPBKgBv-vwzdoPrDQTWnage9prEyJQCeoa52iVpnHic4-AFCqm4_-8QUSI820rffVCTJ4_5btJGASnwrMj_iuLzZi1MP3x4UCtDyiNigl3sZuXOSCCDOLGLo5tysDTcSn2DqA24Zt0gnk1DBxqKKOck24iiuZBNjNJEM-CkR1QpSoKI8uUA5ImAP1M2R9SMUaIBG3S1xhK7YiM8Yo4ciLjmmIMSTaFJU5KDK5l5ZmS9Uie_jBuBs3NfbooPd3-mrBxdC5iRMnh9R7p2LN2efjYLPeVSD7lRuEgmRsSlWZG6iYdnyPax80KCdbCjcOp-BJzSO7qzg_v_Ul8xMRSXKMKUu6LoivadjDAVQ-JSbjIJMfbWIZcEr-ouCezv83CxEDNNUIj7ckx7e3d3e_M8_nYb5eU0ilT6uxe6czGrU_-3p-cMyyrRCMJ5oC6v6t8IfpOCjMDyhAZCL0rROsBJYpRBEklOAS-DmoS6J8kE9DCtLYCe0u079iGPL6G9sH2CtXIl60eEUgxF6yHOMR01MVHUE1LV7Q2cAqo10lhKznH1VMREVauOWMzAhRMQUS3naPWIJbhIk7BbyYLYogTIdrlIqgoqwy7J-Ebr76g019OQI1odAbWoR1ZjVh12tJphVTni1VpVrerRR9hGWt3Voh456baZB2bSUUmgMih9YZ7c5BA0Q0JFGa317C3FCYie4BNfYT8qdnSUHiFHxSCZgeOTecj1YZyCyLCVnP1pLCTW9KhqvqXRQaxlZKKdmY_GoGkYPSk1K9EmsixU1VJp7Rc1aBkuiCYRGvOr1QwjxMMYjf7RckaQyPw7fGXEUU26Jlz2wLISBtSx5cnIyUN5MvujiPIU76AV-KH1d7SqR__KiahqDlBR1UsuIiKoylEQsVWOwnS_kNjiTrNLiKT7PYgcr2YFftQUn0xBte4no8ti-mRsmb6hosWgQWb-TmAytjcPvREYg2ds7ZykpFiH88BWu0K01El2UNPCFFV8Rs-vskJYgRwhBEfxfUaxl49SMh27x4iKR8qMliP44TldKT0ZD5DnjMRsv6Si4tFAuAZisWRPh6r1rUv3qQ6acR8lxziis4mGTzPui_78T8bc_8qeT1xFIwUrGiNAjTsiYGpfbpGYjwD8Tzw4G8imNJppiOt4pBEGeCYnPS8YrZknb6emDQI0PWmYQufKN5fGdDi9rUEtJrYvosYLqF4bu_NQdJDi-sZHC46dS0PIUpv4eEHeL42_ICct8WWr0f1bsUsoKIM8eep20ElQxEsvux9m0FbuEXtgNqJjDxpYBIZWvY7sZUwttOhWxGMIsC_5Ec3vraPQ29dJOrVoQHNpmK1aNJi6NK7P4Lcm_TPFPy-Nbh_MAgg2Eavt2l8cLYNLW07jvjtS6X9F_9TNv1Os_2FZZ9b5P38R8xulmiEPa0NZq9ZPryitDal2zTTTS7H0hlLWUNrWfjXPfzE4M9Ss4APUVtdap5Umt3W7ksN4I3yV8JeTATk9gN5_KnQxpEbieWa3Hu2laL6ghTCPQlhHITpHIbpRRMuJTbLdxWxNHxW7YzfKuAEdljuZf50-iDhVswyFZUB4icVxWmUdyjWm3BjON0EgPCC3k2Fu8VvH8GOW-zS6xWmYFdBoG7M3tN4n1KtAoV4FChWhcc3gmNgnYBUgcI_hkP_g23YREQ7sjZPMcMgn3Qp80q6ARqegQarak1UEWREasmsoZPWDO9AsuX-swiIXcRAcKa84KLNNDkdNrzCFwmq2S6tZxLdDN6SYV7AFrQrSolVa9U5hcxfZx1NoSk6JV5X4CitXNkS7hY1R_lgxS1MoL0OnrOE6VeV2q5AkzsZQw8Tq81a3qtO6XY1GZlkXFa6gSqeWXjWad0sLYhXNWO2yxm5XkNsri6luNX7olaxfylcjZSuoikLRqio1VEbolNbiNFtUtScrcsXJMVJyJ1V2OpgVJIoqaLSrUqiyrPWRkJr6qBdaxNQVOXgmJ64vWLxuGqixrBybyvdcmLcgy_gVRBuvGHWwH7HGHnY30Zfg4jdXztOv_B-CT3-fLUbqZqPsvjud4nWc0z6KdUS66PVsRqmcnaX10iK6ycRQfIEM-9iZybdOxNtGM0wXqdd6jigap4cE3syGT57xxgg9vUkCsiT0aaHeKeNIPmbbfd1o0Iy9PWjuf5_0f7EbtZc=

Before screenshot:

obraz

After screenshot:

obraz

@Paliak Paliak added the enhancement New feature, calculation, or mod label Apr 2, 2024
Paliak and others added 6 commits April 3, 2024 16:59
Sacred wisps causes the Summon Sacred Wisps skill to be triggered when a
projectile spell is fired from a wand. This triggers 2 wisps which then
have an x percent to use the skill that was used to trigger them when
you use it. They likely do not care about whether you actually hit
something with the projectile or not. They're also likely not a trigger
which means they're not under the same tick rounding contrstains like
other triggers.
Sacred wisps support is two part so the SkillTriggerRate check will fail
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, calculation, or mod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calculations for sacred wisp does not update full dps (or hit dps of the skill)
1 participant