Implement Backup & Restore #2302
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredly
commented
Feb 15, 2024
| @@ -14,3 +14,4 @@ org.gradle.unsafe.configuration-cache=true | |||
| voice.signing.play=false | |||
| kotlin.daemon.useFallbackStrategy=false | |||
| org.gradle.kotlin.dsl.allWarningsAsErrors=true | |||
| org.gradle.jvmargs=-Xmx2g | |||
There was a problem hiding this comment.
this was required for me to be able to build the project the first time, but I can back it out if you want
|
Yeah, good to know this isn't implemented yet. Too bad I can't see the reading positions on my old phone, since the SD card that had the books on it has been moved to the new phone already. So I'm SOL I guess. So I guess I should ask if this pull request backs up and restores the reading positions even for books that are no longer available on the device? |
|
@jgilmore I believe it does |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as requested in #1668 and #2103
I'm quite interested in being able to transfer read information, as I'm switching to a new phone and am in the middle of quite a few books 😅
NB I haven't written very much kotlin, so it's entirely likely that I've organized things weirdly. Let me know how you'd like things to be rearranged! I was pretty much just blundering around to get it to compile & work 🙃
But at the end of the day, it does work! I based my implementation fairly loosely on https://stackoverflow.com/a/73205884/290784. I'm exporting the whole sqlite file (including journaling files) as a .zip archive, and then to restore, I overwrite whatever sqlite database exists & restarting the app.
(It might be worth putting up an alert or something saying "Restoring will delete all your current data!" but I wasn't sure how to make an alert)
Here's a video of it in action:
https://github.com/PaulWoitaschek/Voice/assets/112170/d512e8b8-2762-4945-8a54-11ac84c3c952