Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(player): enable audio offloading #2413

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

FineFindus
Copy link
Contributor

Enables the AudioOffloading feature of the Exoplayer, which reduces power consumption and hopefully helps with issues like #2216.

I have not had time to fully test this yet.

@PaulWoitaschek
Copy link
Owner

Iirc it does not work with skip silence and speed adjustments

@barolo
Copy link

barolo commented May 17, 2024

Iirc it does not work with skip silence and speed adjustments

Sorry for hijacking this, but would it be possible to have skipsilence implemented the way NewPipe does it? What I mean is that they don't just cut which is quite jarring but ramp-up instead. AFAIK they're using ExoPlayer too

@FineFindus
Copy link
Contributor Author

Iirc it does not work with skip silence and speed adjustments

Hmm, that would be a bummer? I thought setIsGaplessSupportRequired and setIsSpeedChangeSupportRequired would be enough to be compatible with both features, it is also used in this configuration in other audio players that support both skip silence and speed change.

@PaulWoitaschek
Copy link
Owner

Ooh you are right! I did not check the pr properly, my bad.

I think these changes are dangerous nevertheless. Wdyt about a setting: Experimental audio Player
In the settings menu which enables these newer yet interested things?

@FineFindus
Copy link
Contributor Author

I'm generally not a fan of settings for various reasons (IMHO they're often bad for both the user and the maintainer). Maybe it could be added as an experimental setting first, and after some time, if there are no problems, move to it being enabled by default?

@PaulWoitaschek
Copy link
Owner

Yep that was my idea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants