-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flow API: Custom resume endpoint and blackboxed cdc status endpoint #1711
Draft
Amogh-Bharadwaj
wants to merge
19
commits into
main
Choose a base branch
from
api/custom-resume-endpoint
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serprex
reviewed
May 13, 2024
Amogh-Bharadwaj
force-pushed
the
api/custom-resume-endpoint
branch
from
May 14, 2024 11:17
28edd92
to
3424dca
Compare
Amogh-Bharadwaj
force-pushed
the
api/custom-resume-endpoint
branch
2 times, most recently
from
May 27, 2024 14:04
dcc8e69
to
85da32c
Compare
serprex
reviewed
May 27, 2024
serprex
approved these changes
May 27, 2024
Amogh-Bharadwaj
changed the title
Flow API: Custom resume endpoint
Flow API: Custom resume endpoint and blackboxed cdc status endpoint
May 27, 2024
Description updated with new status endpoint |
Amogh-Bharadwaj
force-pushed
the
api/custom-resume-endpoint
branch
from
May 28, 2024 19:41
a205f79
to
67a3022
Compare
Updated description and functionally tested post changes |
heavycrystal
approved these changes
May 29, 2024
iskakaushik
reviewed
May 29, 2024
Amogh-Bharadwaj
force-pushed
the
api/custom-resume-endpoint
branch
from
May 30, 2024 14:31
5fd1fcb
to
18883e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Endpoints:
Custom sync:
Status:
Authentication
Authentication for both endpoints is the SHA256 hash of the peerdb instance password
API Endpoint to Resume Mirror With Specified Syncs
This PR introduces an endpoint in our Flow API to resume mirrors with a request of custom number of syncs.
MaxSyncsPerCDCFlow
which is currently 32.Implementation:
Extends
CDCFlowConfigUpdate
to include number of syncs information.Functional testing:
Mirror Status Endpoint
Existing mirror status endpoint now has a flag in the request to include flow information. The UI sets this flag. If not set, response only contains flow name and running status, along with clean error messages.
This endpoint is also gated by authorization
Functionally tested