first try at fixing trademacro for ultimatum league #1177

froks · 2021-04-18T10:29:10Z

It seems that the format in the clipboard changed and added a item class line at the beginning; no guarantee it works fully, it did for a few simple test items with this patch

froks · 2021-04-18T10:50:38Z

Seems there are still some issues with some item types (like uniques) looking into it -> should be fixed, we'll see if further issues come up

soockee · 2021-04-18T12:23:51Z

After a brief test for usual use-case with following Commands:

ctrl+c: a windows is popping up
ctrl+d: seems to work as before
ctrl+alt+d: advanced search is working as before
ctrl+w: nothing happens -> seems broken
ctrl+q: nothing happens -> seems broken
ctrl+alt+q: nothing happens - seems broken

So this fix is a progress. thank you ! =)

roobrarcade · 2021-04-18T13:30:15Z

Working for me in game.

When I paste into POB (community fork) it seems to think a rare wand is a unique.

kekemeke · 2021-04-18T14:48:04Z

advanced search doesnt work for rare items ;d
but work for uniq/magick.

anyway ty for the fix ;)

mataski · 2021-04-18T21:48:29Z

Doesn't read rare maps on CTRL+C, reads white and magic, but not rare.

Nivelm · 2021-04-19T00:17:32Z

I found a better solution #1177 (comment)

keep the original ParseItemName function untouched.

It seems that the format in the clipboard changed and added a item class line at the beginning; no guarantee it works fully, it did for a few simple test items with this patch

In POE-ItemInfo.ahk file
ParseItemName(ItemDataChunk, ByRef ItemName, ByRef ItemBaseName, AffixCount = "", ItemData = "")
{
isVaalGem := false
If (RegExMatch(Trim(ItemData.Parts[1]), "i)^Rarity: Gem") and RegExMatch(Trim(ItemData.Parts[2]), "i)Vaal")) {
isVaalGem := true
}

If (RegExMatch(ItemData.NamePlate, "i)Rarity\s?+:\s?+(Currency|Divination Card|Gem)", match)) {
	If (RegExMatch(match1, "i)Gem")) {
		ItemBaseName := Trim(RegExReplace(ItemName, "i) Support"))
	} Else {
		ItemBaseName := Trim(ItemName)
	}		
}

ItemDataChunk := SubStr(ItemDataChunk, InStr(ItemDataChunk,"`n") + 1)    ;   <----- new

Loop, Parse, ItemDataChunk, `n, `r
{

In the original file just insert this line before the loop:
ItemDataChunk := SubStr(ItemDataChunk, InStr(ItemDataChunk,"`n") + 1)
This does the same as your fix. No need to change the inside loop code.
.

xkylieo · 2021-04-19T10:35:23Z

Just to clarify for people
the file is resources\ahk
and your replacing the code with with what he has above
Should look like this
Also leaving my fixed version download
https://www.dropbox.com/s/l2qlh4vppwbs06l/POE-ItemInfo.ahk?dl=0

mataski · 2021-04-19T16:30:41Z

Just to clarify for people
the file is resources\ahk
and your replacing the code with with what he has above
Should look like this
Also leaving my fixed version download
https://www.dropbox.com/s/l2qlh4vppwbs06l/POE-ItemInfo.ahk?dl=0

Any chance of working version on rare maps? CTRL+C only blue/white works.

Nivelm · 2021-04-19T20:47:36Z

I found a better solution that seems to work for everything, advanced search for rare items too.

POE-TradeMacro/resources/ahk/POE-ItemInfo.ahk

Lines 6940 to 6945 in eb20d12

    
           PreProcessContents(CBContents) 
        
           { 
        
           ; --- Place fixes for data inconsistencies here --- 
        
           ; Remove the line that indicates an item cannot be used due to missing character stats	 
        
           	; Matches "Rarity: ..." + anything until "--------"\r\n

Insert this line after ; --- Place fixes for data inconsistencies here ---

CBContents:= SubStr(CBContents, InStr(CBContents,"`n") + 1)    ;      <-- new fix

This removes the first line of clipboard content and "simulate" the previous leagues itemdata format.

Brasolis · 2021-04-19T21:13:31Z

I found a better solution that seems to work for everything, advanced search for rare items too.

POE-TradeMacro/resources/ahk/POE-ItemInfo.ahk

Lines 6940 to 6945 in eb20d12

PreProcessContents(CBContents)

{

; --- Place fixes for data inconsistencies here ---

; Remove the line that indicates an item cannot be used due to missing character stats

; Matches "Rarity: ..." + anything until "--------"\r\n

Insert this line after ; --- Place fixes for data inconsistencies here ---
CBContents:= SubStr(CBContents, InStr(CBContents,"`n") + 1)    ;      <-- new fix
This removes the first line of clipboard content and "simulate" the previous leagues itemdata format.

How do I get this to save? I edit the file and reload the script and it just goes back to how it was before after it tries to update.

Nivelm · 2021-04-19T21:21:55Z

Close your POETrademacro if it is open
Open with Notepad this file in your computer ...\Documents\POE-TradeMacro-2.16.0\resources\ahk\POE-ItemInfo.ahk
(that path is an example) but the file is POE-ItemInfo.ahk
Add that code line
and rerun POETrademacro

Brasolis · 2021-04-19T21:44:31Z

Thanks 👍

AtrejuCodes · 2021-04-20T23:28:17Z

I found a better solution that seems to work for everything, advanced search for rare items too.

POE-TradeMacro/resources/ahk/POE-ItemInfo.ahk

Lines 6940 to 6945 in eb20d12

PreProcessContents(CBContents)

{

; --- Place fixes for data inconsistencies here ---

; Remove the line that indicates an item cannot be used due to missing character stats

; Matches "Rarity: ..." + anything until "--------"\r\n

Insert this line after ; --- Place fixes for data inconsistencies here ---
CBContents:= SubStr(CBContents, InStr(CBContents,"`n") + 1)    ;      <-- new fix
This removes the first line of clipboard content and "simulate" the previous leagues itemdata format.

Working for me thank you

xkylieo · 2021-04-21T12:23:17Z

I found a better solution that seems to work for everything, advanced search for rare items too.

POE-TradeMacro/resources/ahk/POE-ItemInfo.ahk

Lines 6940 to 6945 in eb20d12

PreProcessContents(CBContents)

{

; --- Place fixes for data inconsistencies here ---

; Remove the line that indicates an item cannot be used due to missing character stats

; Matches "Rarity: ..." + anything until "--------"\r\n

Insert this line after ; --- Place fixes for data inconsistencies here ---
CBContents:= SubStr(CBContents, InStr(CBContents,"`n") + 1)    ;      <-- new fix
This removes the first line of clipboard content and "simulate" the previous leagues itemdata format.

can confirm this works for everything
Posting updated Link to fixed ahk file

https://www.dropbox.com/s/l2qlh4vppwbs06l/POE-ItemInfo.ahk?dl=0

adapting new iteminfo format for 3.15

TheL1ne · 2021-08-02T15:42:29Z

@xkylieo I added your changes to the PR.

kuratsak

similar to another PR, using this..

froks mentioned this pull request Apr 18, 2021

Trade Macro Doesn't Respond to Alt+D #1176

Open

first try at fixing trademacro for ultimatum league#

3e2641c

froks force-pushed the master branch from 129485b to 3e2641c Compare April 18, 2021 10:33

froks added 2 commits April 18, 2021 13:01

fix issue with name detection

116dfa4

it's = and not == in autohotkey

d9e58dc

Nivelm mentioned this pull request Apr 19, 2021

Not working #1178

Closed

adapting new iteminfo format for 3.15

a6caf2e

TheL1ne mentioned this pull request Aug 2, 2021

adapting new iteminfo format for 3.15 froks-contrib/POE-TradeMacro#1

Merged

Merge pull request #1 from TheL1ne/master

977e908

adapting new iteminfo format for 3.15

kuratsak approved these changes Sep 24, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

first try at fixing trademacro for ultimatum league #1177

first try at fixing trademacro for ultimatum league #1177

froks commented Apr 18, 2021 •

edited

froks commented Apr 18, 2021 •

edited

soockee commented Apr 18, 2021

roobrarcade commented Apr 18, 2021 •

edited

kekemeke commented Apr 18, 2021 •

edited

mataski commented Apr 18, 2021

Nivelm commented Apr 19, 2021 •

edited

xkylieo commented Apr 19, 2021 •

edited

mataski commented Apr 19, 2021

Nivelm commented Apr 19, 2021

Brasolis commented Apr 19, 2021

Nivelm commented Apr 19, 2021

Brasolis commented Apr 19, 2021

AtrejuCodes commented Apr 20, 2021

xkylieo commented Apr 21, 2021

TheL1ne commented Aug 2, 2021 •

edited

kuratsak left a comment

first try at fixing trademacro for ultimatum league #1177

Are you sure you want to change the base?

first try at fixing trademacro for ultimatum league #1177

Conversation

froks commented Apr 18, 2021 • edited

froks commented Apr 18, 2021 • edited

soockee commented Apr 18, 2021

roobrarcade commented Apr 18, 2021 • edited

kekemeke commented Apr 18, 2021 • edited

mataski commented Apr 18, 2021

Nivelm commented Apr 19, 2021 • edited

xkylieo commented Apr 19, 2021 • edited

mataski commented Apr 19, 2021

Nivelm commented Apr 19, 2021

Brasolis commented Apr 19, 2021

Nivelm commented Apr 19, 2021

Brasolis commented Apr 19, 2021

AtrejuCodes commented Apr 20, 2021

xkylieo commented Apr 21, 2021

TheL1ne commented Aug 2, 2021 • edited

kuratsak left a comment

Choose a reason for hiding this comment

froks commented Apr 18, 2021 •

edited

froks commented Apr 18, 2021 •

edited

roobrarcade commented Apr 18, 2021 •

edited

kekemeke commented Apr 18, 2021 •

edited

Nivelm commented Apr 19, 2021 •

edited

xkylieo commented Apr 19, 2021 •

edited

TheL1ne commented Aug 2, 2021 •

edited