-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: network waterfall view for session replay #22349
Conversation
Size Change: +58 B (+0.01%) Total Size: 1.03 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
@daibhin thought I'd put something up you can play with to get UX feedback - am already thinking it should be called "page report" not "network view" |
This feels cool. Great to give people another means of analysing their data. I made two larger changes:
I think the main question I took away from it all was why this is a separate tab to the recordings? I'd imagine it would be quite annoying to have to switch between the two tabs and find a recording again if you want to look at the waterfall view. Do we expect someone to use this while analysing a recording or is it something they'd intentionally come to do? Could this be a different view on the existing recording that you can toggle to? Or maybe it could just be another tab in the inspector? |
Yeah, I think eventually you'd want to be able to visit individual page reports, share them, export them. It was separate mostly just cos I was figuring it out as I go. And a way to promote the feature more easily. I don't think it should live only in the inspector. It feels too restricted. I'd be keen to get it in behind a flag so we can see the display with some production data to sense check that. |
super confused why moving the initiator type color mapping has broken all uses of color in js tests 🫠 |
📸 UI snapshots have been updated3 snapshot changes in total. 0 added, 3 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated4 snapshot changes in total. 0 added, 4 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
low context approval given :D since it's behind a flag anyways
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: David Newell <david@posthog.com>
#TravelHackathon
We have all the data we need to generate page reports in individual recording's session replay data
We can't make it queryable but we can display it individually, that's already useful so let's do that
TODO
if it's a mode of the player we can ignore