feat: show estimated rows #22350
feat: show estimated rows #22350
Conversation
WalkthroughThe recent update in the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Review Details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Files selected for processing (1)
- frontend/src/scenes/insights/EmptyStates/EmptyStates.tsx (2 hunks)
Additional comments not posted (1)
frontend/src/scenes/insights/EmptyStates/EmptyStates.tsx (1)
121-121: Ensure the calculation forestimatedRowsis correct and optimized.Verification successful
The calculation for
estimatedRowsappears to be correct and consistent within the codebase. TheinsightPollResponse,status, andquery_progressare properly defined and used in theEmptyStates.tsxfile.
insightPollResponseis obtained fromuseValues(insightDataLogic(insightProps)).statusandquery_progressare accessed correctly frominsightPollResponse.No further issues were found regarding the calculation and usage of
estimatedRows.Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the calculation for `estimatedRows` is correct and optimized. # Test: Search for similar calculations in the codebase. Expect: Consistent and optimized usage. rg --type typescript $'insightPollResponse?.status?.query_progress?.estimated_rows_total'Length of output: 125
Script:
#!/bin/bash # Description: Verify the calculation for `estimatedRows` is correct and optimized. # Find all TypeScript files and search for the pattern within those files. fd --extension ts --exec rg 'insightPollResponse?.status?.query_progress?.estimated_rows_total' {}Length of output: 102
Script:
#!/bin/bash # Description: Verify the definitions and usages of `insightPollResponse`, `status`, and `query_progress`. # Search for the definition and usage of `insightPollResponse`. rg 'insightPollResponse' --type ts # Search for the definition and usage of `status` within the context of `insightPollResponse`. rg 'insightPollResponse.*status' --type ts # Search for the definition and usage of `query_progress` within the context of `status`. rg 'status.*query_progress' --type tsLength of output: 2520
| {humanFriendlyNumber(rowsRead || 0, 0)}{' '} | ||
| {estimatedRows && estimatedRows >= rowsRead | ||
| ? `/ ${humanFriendlyNumber(estimatedRows)} ` | ||
| : null}{' '} | ||
| rows |
There was a problem hiding this comment.
Review the display logic for estimatedRows to ensure clarity and accuracy.
Consider adding a label or tooltip to clarify what "estimated rows" means to the user, especially if the actual number of rows can significantly differ from the estimate.
|
Size Change: +240 B (+0.02%) Total Size: 1.05 MB ℹ️ View Unchanged
|
Show a target of estimated rows