fix: async validation errors #22351
Merged
fix: async validation errors #22351
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +172 B (+0.02%) Total Size: 1.05 MB ℹ️ View Unchanged
|
Twixes
reviewed
May 20, 2024
| @@ -329,6 +329,10 @@ export const insightVizDataLogic = kea<insightVizDataLogicType>([ | |||
| validationError: [ | |||
| (s) => [s.insightDataError], | |||
| (insightDataError): string | null => { | |||
| // Handle Async Queries here | |||
| if (insightDataError?.data?.error_message) { | |||
There was a problem hiding this comment.
Quick question: does this only apply to async HogQL queries, or HogQL queries overall? Because if the shape of insightDataError is different for async ones specifically, that sounds like a minefield
There was a problem hiding this comment.
InsightDataError is different for sync and async. See below:
Sync
Async
The "status" field does work correctly, but the error message is in a different place.
There was a problem hiding this comment.
Ah, so they're pretty significantly different. That's a bit annyoing. But let's maybe keep as is for now, and only fix the problem at hand.
Twixes
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Async user surfaceable queries don't have user friendly errors
#21270
Changes
Does this work well for both Cloud and self-hosted?
Yes
How did you test this code?
Tested locally