-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New Engine] Add flow run pause handling #13264
Conversation
✅ Deploy Preview for prefect-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
99144d4
to
c9ac882
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a (more?) common pattern is pausing from within the body of a flow - that seems like it would require analogous changes to the new flow run engine yea?
AFAICT, The changes in the task engine prevent a task from starting if the parent flow is paused, which can happen if the task is submitted to remote infrastructure. That hasn't been needed for flow runs because they have historically been blocking, but I could see that changing with the new engine. We would also need an orchestration rule to prevent starting flow runs from a paused parent run, so I think that might be best tackled in another PR. |
@desertaxle ah wow, that's nice! Thanks for explaining |
Adds handling for paused flow run to the new engine. Changes to the new engine are relatively small, and this PR mostly contains tests for the new verifying that pausing flow runs works as expected.
Example
Checklist
<link to issue>
"maintenance
,fix
,feature
,enhancement
,docs
.For documentation changes:
netlify.toml
for files that are removed or renamed.For new functions or classes in the Python SDK:
mkdocs.yml
navigation.