-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[prefect-docker] add cached docker build and push steps #13286
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for prefect-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is rad! Alex and I were talking with a user yesterday about this exact issue
@zzstoatzz What do you think about incorporating this behavior into the existing steps? That way users get caching with no changes needed. We could have the caching behavior be opt-out with a |
I was debating on whether to do that - yeah I can incorporate that into the existing steps |
This pull request is stale because it has been open 14 days with no activity. To keep this pull request open remove stale label or comment. |
this will cache the results of the existing build and push steps in memory so that if the same build or push is requested during a
build
step more than once, it will no-op and the result will be fetched from the cachethis is an alternative way to address #9921
i could see the argument that we should simply add caching to the existing step, but it felt like I needed a layer to handle the
list
/dict
(non-hashable) inputs and avoid any potential weirdness associated with changing the canonical stepusage