[new engine] use new engine for background tasks #13303
Draft
+66
−77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for prefect-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
zzstoatzz
commented
May 10, 2024
src/prefect/new_task_engine.py
Outdated
Comment on lines
379
to
388
| run.begin_run() | ||
| with run.enter_run_context(): | ||
| run.begin_run() | ||
|
|
||
| while run.is_running(): | ||
| with run.enter_run_context(): | ||
| while run.is_running(): |
There was a problem hiding this comment.
this may not be what we want, but this is to address the fact that task_input_hash uses the TaskRunContext, which would not exist unless we first enter the context
There was a problem hiding this comment.
I think some of @cicdw's work may preclude this, pinging in case
|
This pull request is stale because it has been open 14 days with no activity. To keep this pull request open remove stale label or comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example
Checklist
<link to issue>"maintenance,fix,feature,enhancement,docs.For documentation changes:
netlify.tomlfor files that are removed or renamed.For new functions or classes in the Python SDK:
mkdocs.ymlnavigation.