Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose a ui-setting for automations. #13324

Closed
wants to merge 2 commits into from

Conversation

collincchoy
Copy link
Contributor

This PR follows #13323 and exposes another ui-setting flag for automations.

The automation apis are enabled only if both PREFECT_EXPERIMENTAL_ENABLE_EVENTS and PREFECT_API_SERVICES_TRIGGERS_ENABLED are enabled. Because this is a "compound" flag, I've opted to just compute it on-the-fly as a "ui-only setting".

@collincchoy collincchoy requested review from zangell44 and a team as code owners May 13, 2024 21:36
@collincchoy collincchoy added the maintenance Chores and other work not directly related to the product label May 13, 2024
Copy link
Contributor

@bunchesofdonald bunchesofdonald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Base automatically changed from fix-events-setting-name to main May 14, 2024 15:56
Copy link

netlify bot commented May 14, 2024

Deploy Preview for prefect-docs-preview ready!

Name Link
🔨 Latest commit 5de4ec2
🔍 Latest deploy log https://app.netlify.com/sites/prefect-docs-preview/deploys/66438aeb3b079400086f8941
😎 Deploy Preview https://deploy-preview-13324--prefect-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@collincchoy collincchoy force-pushed the expose-automations-enabled-to-ui branch from cfab091 to 5de4ec2 Compare May 14, 2024 16:01
@collincchoy
Copy link
Contributor Author

Closing this as should be on by default in 3.0. See #13335

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Chores and other work not directly related to the product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants