Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Defer imports for type annotations in engines under if TYPE_CHECKING guard #13325

Closed
wants to merge 10 commits into from
Closed

Defer imports for type annotations in engines under if TYPE_CHECKING guard #13325

wants to merge 10 commits into from

Conversation

serinamarie
Copy link
Contributor

Example

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • This pull request includes a label categorizing the change e.g. maintenance, fix, feature, enhancement, docs.

For documentation changes:

  • This pull request includes redirect settings in netlify.toml for files that are removed or renamed.

For new functions or classes in the Python SDK:

  • This pull request includes helpful docstrings.
  • If a new Python file was added, this pull request contains a stub page in the Python SDK docs and an entry in mkdocs.yml navigation.

@serinamarie serinamarie changed the title Add type checking to engine Use type checking in engines May 13, 2024
@serinamarie serinamarie changed the title Use type checking in engines Defer imports for type annotations under if TYPE_CHECKING guard May 13, 2024
@serinamarie serinamarie changed the title Defer imports for type annotations under if TYPE_CHECKING guard Defer imports for type annotations in engines under if TYPE_CHECKING guard May 13, 2024
serinamarie
serinamarie commented May 14, 2024
View reviewed changes
src/prefect/new_task_engine.py
if TYPE_CHECKING:
from prefect import Task
from prefect.client.orchestration import SyncPrefectClient
from prefect.client.schemas import State, TaskRun
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes this to client schema for State

Base automatically changed from lessen-time-spent-in-pull to main May 14, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@serinamarie