Implement sprinting mechanics #4801
Conversation
to make sure it's always running, also add a hotkey in the ability bar for sprinting
ender-titan1
force-pushed
the
sprinting-mechanics
branch
from
79b49ca
to
6adb998
Compare
and add support for excess strain
| @@ -141,7 +141,7 @@ protected override void Update(float delta, in Entity entity) | |||
| /// </summary> | |||
| private void ApplyATPDamage(CompoundBag compounds, ref Health health, ref CellProperties cellProperties) | |||
| { | |||
| if (compounds.GetCompoundAmount(atp) > 0) | |||
| if (compounds.GetCompoundAmount(atp) > 0.1f) | |||
There was a problem hiding this comment.
Why is this needed? I think this may have massive implications on taking ATP damage when trying to move.
There was a problem hiding this comment.
This was changed as ATP never reached a low enough level for it to do damage. The bar would look empty but no damage would be done. Should've probably set it to something lower though.
There was a problem hiding this comment.
Adjusting when the ATP is taken would be a better choice. That's what's been done in the past to ensure cells can be damaged (for example making this run before whatever system applies ATP damage, but after the process system).
There was a problem hiding this comment.
I ended up changing this to 0.05f, as I couldn't get this to work otherwise. I think it's sensible to set it to that, as the difference at that point is barely noticeable and I don't think it would have any major implications.
There was a problem hiding this comment.
Could you add a comment before this if to explain the number? Or actually I think it'd be pretty nice to make it a constant in Constants and add a summary comment explaining the reason for it there.
|
I think mechanically, this feature is mostly ready. But since it still needs some work maybe it should be classed as an "experimental feature"? To recap, what is needed is balance, AI implementation, a tutorial and maybe some graphics improvements. |
|
I suppose without those still undone parts classifying this as an experimental feature would be an option to merge this soon. |
|
This should be ready for merge now. I've fixed everything from the review. |
| @@ -311,6 +317,18 @@ protected override void UpdateHealth(float delta) | |||
| hpLabel.HintTooltip = hpText; | |||
| } | |||
|
|
|||
| protected override float? ReadPlayerStrainFraction() | |||
| { | |||
| if (stage!.Player.Has<StrainAffected>() && !playerMissingStrainAffected) | |||
There was a problem hiding this comment.
I think first condition should be with ! at the beggining
| @@ -53,6 +53,11 @@ public struct MicrobeControl | |||
| /// </summary> | |||
| public bool SlowedBySlime; | |||
|
|
|||
| /// <summary> | |||
| /// Whether this microbe is currenyly sprinting | |||
|
We are currently in feature freeze until the next release. |
|
Limited testing due to battery issues with my laptop. I am not sure how it scales with greater mass, but sprinting felt pretty good in the few generations I played. Great job implementing a feature that makes movement atleast a bit more engaging than pointing your mouse in a direction and pressing W. One thing though: in the original concept, sprinting was attached to the flagella as an ability rather than a default ability, which synergizes with the flagella providing upgrades changing the behavior of sprinting. Was it an intentional decision to have it be available from the get go? |
|
Oh I wasn't expecting this to be reviewed. Slight heads up that this will probably have to be changed into a new Godot 4 branch. I don't recall there being a particular reason for why the sprinting is enabled by default, iirc it was just an arbitrary decision that's pretty easy to change if needed. However I did intentionally leave out flagella upgrades for the simple reason that I found them too hard to implement and decided to do them down the line when the basic system was done. |
Brief Description of What This PR Does
This PR implements sprinting and cell strain to the game.
To do:
Maybe:
Related Issues
https://forum.revolutionarygamesstudio.com/t/organism-stamina-mechanics/757/7
Progress Checklist
Note: before starting this checklist the PR should be marked as non-draft.
break existing features:
https://wiki.revolutionarygamesstudio.com/wiki/Testing_Checklist
(this is important as to not waste the time of Thrive team
members reviewing this PR)
styleguide.
Before merging all CI jobs should finish on this PR without errors, if
there are automatically detected style issues they should be fixed by
the PR author. Merging must follow our
styleguide.