Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes 3d background comets #5136

Merged

Conversation

HexapodPhilosopher
Copy link
Contributor

@HexapodPhilosopher HexapodPhilosopher commented May 18, 2024

Brief Description of What This PR Does

Rescales rocks used in comets in 3d background to look like they should.

Related Issues

Progress Checklist

Note: before starting this checklist the PR should be marked as non-draft.

  • PR author has checked that this PR works as intended and doesn't
    break existing features:
    https://wiki.revolutionarygamesstudio.com/wiki/Testing_Checklist
    (this is important as to not waste the time of Thrive team
    members reviewing this PR)
  • Initial code review passed (this and further items should not be checked by the PR author)
  • Functionality is confirmed working by another person (see above checklist link)
  • Final code review is passed and code conforms to the
    styleguide.

Before merging all CI jobs should finish on this PR without errors, if
there are automatically detected style issues they should be fixed by
the PR author. Merging must follow our
styleguide.

@HexapodPhilosopher HexapodPhilosopher marked this pull request as ready for review May 18, 2024 13:44
@hhyyrylainen
Copy link
Member

It probably uses the same scene, but just to confirm, does this also fix the comet that is placed into the space stage?

@CI09
Copy link
Contributor

CI09 commented May 18, 2024

I can test in a moment.

Copy link
Contributor

@CI09 CI09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works.

@hhyyrylainen hhyyrylainen added this to the Release 0.6.7 milestone May 20, 2024
@hhyyrylainen hhyyrylainen merged commit f8e4655 into Revolutionary-Games:master May 20, 2024
4 checks passed
@HexapodPhilosopher HexapodPhilosopher deleted the cometfix branch May 20, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants