-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: sidebar last message E2EE #32431
base: develop
Are you sure you want to change the base?
Conversation
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: b5b820c The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32431 +/- ##
===========================================
- Coverage 55.81% 55.64% -0.17%
===========================================
Files 2413 2408 -5
Lines 53160 53020 -140
Branches 10925 10901 -24
===========================================
- Hits 29669 29503 -166
- Misses 20871 20905 +34
+ Partials 2620 2612 -8
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Proposed changes (including videos or screenshots)
If End-to-End Encryption is enabled and you delete the last message in a room the is updated to the last message without a type (t) attribute set which will be last message before the encryption was enabled for this room or no message if no unencrypted message is available.
If you send an encrypted message the lastMessage is updated correctly but on deletion the method Rooms.resetLastMessageById is called which will get the last message by calling Messages.getLastVisibleMessageSentWithNoTypeByRoomId. But an e2e message has the t set to "e2e" and will be ignored.
I did:
Messages.getLastVisibleMessageSentWithNoTypeByRoomId
function toMessages.getLastVisibleUserMessageSentByRoomId
Issue(s)
Steps to test or reproduce
Expected behavior:
The last message is shown nevermind if its an encrypted or unencrypted message
Further comments
https://rocketchat.atlassian.net/browse/E2EE2-12