Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Translations falling back to english after refreshing the page #32442

Merged
merged 1 commit into from
May 20, 2024

Conversation

dionisio-bot[bot]
Copy link
Contributor

@dionisio-bot dionisio-bot bot commented May 15, 2024

Backport of #32348

@dionisio-bot dionisio-bot bot requested a review from a team as a code owner May 15, 2024 14:08
@dionisio-bot dionisio-bot bot requested a review from gabriellsh May 15, 2024 14:08
Copy link

changeset-bot bot commented May 15, 2024

🦋 Changeset detected

Latest commit: 75c379b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor Author

dionisio-bot bot commented May 15, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-6.7.3@57988b8). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##             release-6.7.3   #32442   +/-   ##
================================================
  Coverage                 ?   54.80%           
================================================
  Files                    ?     2300           
  Lines                    ?    50776           
  Branches                 ?    10372           
================================================
  Hits                     ?    27830           
  Misses                   ?    20490           
  Partials                 ?     2456           
Flag Coverage Δ
unit 75.81% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo
Copy link
Member

ggazzo commented May 20, 2024

/rebase

Copy link
Contributor Author

dionisio-bot bot commented May 20, 2024

    Sorry, I couldn't rebase this pull request because of conflicts. Could you please solve them?
    
    you can do so by running the following commands:
git fetch
git checkout backport-6.7.3-32348
git cherry-pick dd0bbcecd4506080b5f42698f123b93537a9636a
// solve the conflict
git push

…32348)

Co-authored-by: Guilherme Gazzo <5263975+ggazzo@users.noreply.github.com>
@ggazzo ggazzo reopened this May 20, 2024
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label May 20, 2024
@ggazzo ggazzo added this to the 6.7 milestone May 20, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label May 20, 2024
@kodiakhq kodiakhq bot merged commit 2034600 into release-6.7.3 May 20, 2024
19 checks passed
@kodiakhq kodiakhq bot deleted the backport-6.7.3-32348 branch May 20, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants