-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: QueueInactivityMonitor
not processing inquiries
#32452
base: develop
Are you sure you want to change the base?
Conversation
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: 10b0bda The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #32452 +/- ##
===========================================
+ Coverage 55.84% 55.88% +0.04%
===========================================
Files 2432 2434 +2
Lines 53478 53535 +57
Branches 10992 10995 +3
===========================================
+ Hits 29864 29920 +56
- Misses 20975 20976 +1
Partials 2639 2639
Flags with carried forward coverage won't be shown. Click here to find out more. |
Note: no tests for this as the minimum time for this job to run is one min and waiting for the CI to run after one min is no good Will create a separate task to add unit tests |
Proposed changes (including videos or screenshots)
Issue(s)
https://rocketchat.atlassian.net/browse/SUP-579
Steps to test or reproduce
Further comments
Apparently the callback that created the job to remove the items from the queue was checking a
createdAt
property that didn't even exists on types. Since the function was typed asany
, this created the perfect place for this happen.Types were updated, missing property check was removed (now we just check for _updatedAt) and changed the use of a global value since we have the value in scope from the
watch
call.