Chess: Port application to GML #24329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
👀 pr-needs-review
There was a problem hiding this comment.
Looks good overall, but some things needs to be changed. If I were you, I would make the changes this way:
- Put everything needed in the
Chessnamespace, addGfx::where needed - Make "functional" changes (background color, and adding the ellipsis)
- Do the actual port to GML
tcl3
reviewed
May 14, 2024
This is required to port the application to GML.
d-gaston
force-pushed
the
chess-gml
branch
2 times, most recently
from
6414f5e
to
e79414f
Compare
LucasChollet
approved these changes
May 15, 2024
This commit ports the chess application to GML in order to facilitate the addition of widgets in the future.
LucasChollet
added
✅ pr-community-approved
github-actions
bot
removed
the
✅ pr-community-approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the chess application to the
Chessnamespaces and then ports thechess application to GML in order to facilitate the addition of widgets in the future.