LibGfx/GIF: Support Colors #24330
Merged
LibGfx/GIF: Support Colors #24330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
👀 pr-needs-review
nico
reviewed
May 15, 2024
nico
approved these changes
May 15, 2024
No it doesn't, as an example the image in the PR description has more than 256 colors. It TODOs if the input color was not present during the creation of the palette. Currently, there is no way to hit that TODO in the code. But we will quickly face it if we try to encode new frames with the same palette. I started to resolve some comment locally, but I'll do the rest tomorrow. |
LucasChollet
force-pushed
the
gif_colors
branch
2 times, most recently
from
f188bb1
to
c1e43d8
Compare
nico
reviewed
May 18, 2024
nico
reviewed
May 18, 2024
nico
added
⏳ pr-waiting-for-author
github-actions
bot
added
👀 pr-needs-review
nico
added
✅ pr-community-approved
|
(maintainers: feel free to hit merge! My 2 comments below are minor nits and optional, and can be in a follow-up of they're addressed at all. I'm excited about having this in tree.) |
This is useful to find the best matching color palette from an existing bitmap. It can be used in PixelPaint but also in encoders of old image formats that only support indexed colors e.g. GIF.
To determine the palette of colors we use the median cut algorithm. While being a correct implementation, enhancements are obviously existing on both the median cut algorithm and the encoding side.
github-actions
bot
added
👀 pr-needs-review
github-actions
bot
removed
the
👀 pr-needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can clearly see the lack of diversity in the colors due to the size of the table being limited to 256 elements.