Toolchain: Set cpu_family in meson cross files to SERENITY_ARCH #24336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
👀 pr-needs-review
kennethmyhra
force-pushed
the
meson-cross-files-cpu-family
branch
from
24dff68
to
acae720
Compare
kennethmyhra
changed the title
kennethmyhra
force-pushed
the
meson-cross-files-cpu-family
branch
from
acae720
to
5ad736b
Compare
kennethmyhra
force-pushed
the
meson-cross-files-cpu-family
branch
from
5ad736b
to
1103c40
Compare
|
Unrelated flakiness on macOS runner. |
github-actions
bot
removed
the
👀 pr-needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed these were still set to
x86while playing around with enabling the dynamic core on ourdosbox-stagingport.EDIT:
Switching to the environment variable
SERENITY_ARCHinstead of the hardcoded value forcpu_family. Seems that bothcpu_familyandcpuis supposed have the valuex86_64 in our case: https://mesonbuild.com/Cross-compilation.html#cross-compilation