Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LibWeb: Use correct type for MessageEventInit.ports #24338

Merged

Conversation

tcl3
Copy link
Member

@tcl3 tcl3 commented May 15, 2024

This didn't work previously because the IDL generator used the incorrect type for some types of sequences within dictionaries.

@github-actions github-actions bot added the 👀 pr-needs-review PR needs review from a maintainer or community member label May 15, 2024
@tcl3 tcl3 force-pushed the libweb_messageeventinit_correct_type branch from 1c66864 to f4ebaf6 Compare May 15, 2024 20:59
This didn't work previously because the IDL generator used the
incorrect type for some types of sequences within dictionaries.
@tcl3 tcl3 force-pushed the libweb_messageeventinit_correct_type branch from f4ebaf6 to 48920fd Compare May 16, 2024 00:10
@awesomekling awesomekling merged commit 6324657 into SerenityOS:master May 16, 2024
11 checks passed
@tcl3 tcl3 deleted the libweb_messageeventinit_correct_type branch May 16, 2024 06:11
@github-actions github-actions bot removed the 👀 pr-needs-review PR needs review from a maintainer or community member label May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants