LibWeb: Implement FontFace.load() for url() based font sources #24339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
👀 pr-needs-review
ADKaster
commented
May 15, 2024
Comment on lines
5
to
9
| // FIXME: Surely there's a better way to get this font URL | ||
| let fontUrl = new URL(location.href); | ||
| fontUrl.search = ""; | ||
| fontUrl += "/../../../../Ref/assets/HashSans.woff"; | ||
| println(`fontUrl: ${fontUrl}`) |
There was a problem hiding this comment.
halp, how to URL in javascript (edit: outdated b/c I removed the println, not because I found a sane way to get the url to the font).
This is useful for when we want to parse paths relative to the current ESO's api base url when there isn't a document, such as in a Worker context.
We'll want to explicitly load fonts from FontFace and other Web APIs in the future. A future refactor should also move this completely away from StyleComputer and call it something like 'FontCache'.
github-actions
bot
removed
the
👀 pr-needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And make a bit of a mess out of StyleComputer::FontLoader in the process :^)