Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Solitaire #64

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

WIP: Solitaire #64

wants to merge 5 commits into from

Conversation

IgorMacGregor
Copy link

Hi guys,
Here is my up to date version of the Solitaire view (with Hooks !), I will now focus on the logic of the game, but I will need some time to understand how to deal with the different events of a game. Sorry, I had to create a new pull request, I was struggling hard with Git for the last two days :'(
Have a good day !

@vercel
Copy link

vercel bot commented Apr 18, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://winxp-git-fork-igormacgregor-wipaddsolitaireview.shizukuichi.now.sh

@ShizukuIchi
Copy link
Owner

Hi @IgorMacGregor! You should change some of your lint rules such as single quote, comma-dangle.

@IgorMacGregor
Copy link
Author

Hi, I'm still working on the solitaire and I would maybe need some advice up to this point. Here are the new changes:

  • Added drag functionality on cards, which is a bit slow. How could I make it faster so that the card follows exactly the cursor ?
  • Added drop functionality on bottom stacks. Here, I have been stuck for three days as I can only move one card, and when I move another one the global state forgets the previous move ... (I have disabled the randomization of the game so that it is easier to test two moves)
  • Also, to make the drop event fired, I needed to lower the z-index of the moving card, whereas in the real solitaire game it is ahead of the rest of the game, and I'm still thinking to how to deal with that.

If you have any advice/solution to my problems tell me !
Thanks !!

@IgorMacGregor
Copy link
Author

Hey, I have made some changes which allow in a strange way to make several moves, I think it was because of a closure issue but now it works :) I have also worked on making deck and topslots functional.
From now on, I think my React skills are too limited, particularly for making several cards move, so if someone wants to work on the Solitaire some help would be much needed :)
There is still some lags problems and the z-index issue. Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants