Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed an infinite loop when selecting desktop icons #97

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

m417z
Copy link

@m417z m417z commented Jun 5, 2021

The problem was that a new onIconsSelected function was created on each render, causing the following infinite loop:

  • WinXP() is called.
  • A new onIconsSelected function is passed to <Icons />.
  • useEffect is called inside Icons(), and setSelectedIcons is called.
  • setSelectedIcons triggers a dispatch, causing WinXP() to be called again.

To fix this, I wrapped setSelectedIcons with useCallback. And while at it, I wrapped all other functions.

@vercel
Copy link

vercel bot commented Jun 5, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/shizukuichi/winXP/AwLsNmPBA6QutX2DU9Uxf3jguHPk
✅ Preview: https://winxp-git-fork-m417z-patch-2-shizukuichi.vercel.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant