-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] improve cloud native pk table memory cost when handle large ingestion #45685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luohaha
force-pushed
the
lake-pk-large-ingest
branch
4 times, most recently
from
May 16, 2024 13:06
0ee75d1
to
5128ed3
Compare
srlch
approved these changes
May 21, 2024
…arge ingestion Signed-off-by: luohaha <18810541851@163.com>
luohaha
force-pushed
the
lake-pk-large-ingest
branch
from
May 21, 2024 09:08
5128ed3
to
c3c2d56
Compare
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]✅ pass : 315 / 337 (93.47%) file detail
|
sevev
approved these changes
May 23, 2024
TszKitLo40
approved these changes
May 23, 2024
decster
approved these changes
May 24, 2024
wyb
approved these changes
May 24, 2024
@Mergifyio backport branch-3.3 |
@Mergifyio backport branch-3.2 |
✅ Backports have been created
|
✅ Backports have been created
|
42 tasks
mergify bot
pushed a commit
that referenced
this pull request
May 24, 2024
…arge ingestion (#45685) Signed-off-by: luohaha <18810541851@163.com> (cherry picked from commit a092277) # Conflicts: # be/src/storage/lake/rowset_update_state.cpp # be/src/storage/lake/rowset_update_state.h # be/src/storage/lake/update_manager.cpp # be/src/storage/rowset/segment_rewriter.cpp # be/src/storage/rowset/segment_rewriter.h # be/test/storage/lake/partial_update_test.cpp
42 tasks
ignore backport check: 3.2.8 |
luohaha
added a commit
to luohaha/starrocks
that referenced
this pull request
Jun 3, 2024
…arge ingestion (StarRocks#45685) Signed-off-by: luohaha <18810541851@163.com>
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
In current implementation, if one ingest in tablet has multi segment files, and SR will load all segment file state at once, which will cost lots of memory if this ingestion is large, and it will lead to OOM. We need to avoid OOM when handle large ingestion.
What I'm doing:
write_buffer_size
).update
memory is not limited.What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: