[Refactor] Introduce ColumnId to support Column renaming (part3) #45757
+483
−239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gengjun-git
changed the title
| @@ -267,7 +268,7 @@ protected void runPendingJob() throws AlterCancelException { | |||
| .setShortKeyColumnCount(rollupShortKeyColumnCount) | |||
| .setSchemaHash(rollupSchemaHash) | |||
| .setStorageType(TStorageType.COLUMN) | |||
| .setBloomFilterColumnNames(tbl.getCopiedBfColumns()) | |||
| .setBloomFilterColumnNames(tbl.getBfPhysicalColumnNames()) | |||
There was a problem hiding this comment.
what does physical column name mean? should be columnID?
| @@ -567,9 +568,13 @@ protected void runWaitingTxnJob() throws AlterCancelException { | |||
| "found in the base table."); | |||
| } | |||
| } | |||
|
|
|||
| List<ColumnId> usedPhysicalNames = new ArrayList<>(usedBaseTableColNames.size()); | |||
There was a problem hiding this comment.
Suggested change
| List<ColumnId> usedPhysicalNames = new ArrayList<>(usedBaseTableColNames.size()); | |
| List<ColumnId> usedColumnIds = new ArrayList<>(usedBaseTableColNames.size()); |
| public static FieldId create(String raw) { | ||
| if (raw.contains("\\.")) { | ||
| String[] fields = raw.split("\\.", 2); | ||
| return new FieldId(ColumnId.create(fields[0]), fields[1]); |
gengjun-git
force-pushed
the
rename_col_column_name
branch
from
4feb5ab
to
6d46d23
Compare
gengjun-git
force-pushed
the
rename_col_column_name
branch
from
5e69af9
to
6336fff
Compare
|
[FE Incremental Coverage Report]✅ pass : 184 / 230 (80.00%) file detail
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
We need a unique ID to identify the Column. This ID is used in all places that reference the Column. In this way, to change the attributes of the Column, such as name, we only need to change the attributes in the Column object. There is a uniqueId in the current Column, but it is only available in newly created tables. For compatibility reasons, we need to introduce another Id: ColumnID. The ColumnID of the historical table is the name of the column, because the name was previously immutable.
What I'm doing:
There are currently three ways to reference Column: 1: direct copy of Column object, 2: reference to Column name, 3: sql expression reference.
This PR changes the Column name to ColumnId reference.
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: