[BugFix] cleanup in-memory partition state if check fail when creating multiple-partitions

[mofeiatwork]

Why I'm doing:

What I'm doing:

Fixes SR-26924

What type of PR is this:

• BugFix
• Feature
• Enhancement
• Refactor
• UT
• Doc
• Tool

Does this PR entail a change in behavior?

• Yes, this PR will result in a change in behavior.
• No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

• Interface/UI changes: syntax, type conversion, expression evaluation, display information
• Parameter changes: default values, similar parameters but with different default values
• Policy changes: use new policy to replace old one, functionality automatically enabled
• Feature removed
• Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

• I have added test cases for my bug fix or my new feature
• This pr needs user documentation (for new or modified features or behaviors)
  • I have added documentation for my new feature or new function
• This is a backport pr

Bugfix cherry-pick branch check:

• I have checked the version labels which the pr will be auto-backported to the target branch
  • 3.3
  • 3.2
  • 3.1
  • 3.0
  • 2.5

[starrocks-cr]

The most risky bug in this code is:
Inconsistent handling of exceptions for partially processed partition entries leading to potential data inconsistency or resource leak.

You can modify the code like this:

@@ -253,25 +253,38 @@ public void createAutomaticShadowPartition(long partitionId, String replicateNum
 public void handleNewRangePartitionDescs(List<Pair<Partition, PartitionDesc>> partitionList,
                                          Set<String> existPartitionNameSet,
                                          boolean isTemp) throws DdlException {
+    List<Long> successfullyProcessedPartitions = new ArrayList<>();
     try {
         for (Pair<Partition, PartitionDesc> entry : partitionList) {
             Partition partition = entry.first;
             if (!existPartitionNameSet.contains(partition.getName())) {
                 long partitionId = partition.getId();
                 SingleRangePartitionDesc desc = (SingleRangePartitionDesc) entry.second;
                 Preconditions.checkArgument(desc.isAnalyzed());
                 Range<PartitionKey> range;
                 try {
                     range = checkAndCreateRange((SingleRangePartitionDesc) entry.second, isTemp);
                     setRangeInternal(partitionId, isTemp, range);
+                    successfullyProcessedPartitions.add(partitionId); // Add ID to list after successful processing
                 } catch (IllegalArgumentException e) {
                     // Range.closedOpen may throw this if (lower > upper)
                     throw new DdlException("Invalid key range: " + e.getMessage());
                 }
                 idToDataProperty.put(partitionId, desc.getPartitionDataProperty());
                 idToReplicationNum.put(partitionId, desc.getReplicationNum());
                 idToInMemory.put(partitionId, desc.isInMemory());
                 idToStorageCacheInfo.put(partitionId, desc.getDataCacheInfo());
             }
         }
     } catch (Exception e) {
         // cleanup only for processed partitions
-        partitionList.forEach(entry -> {
+        successfullyProcessedPartitions.forEach(partitionId -> {
             removeRangeInternal(partitionId, isTemp);
             idToDataProperty.remove(partitionId);
             idToReplicationNum.remove(partitionId);
             idToInMemory.remove(partitionId);
             idToStorageCacheInfo.remove(partitionId);
         });
         throw e;
     }
 }

This modification ensures that the cleanup process applies only to those partitions that were successfully processed before an exception occurred, thus preventing removal or alteration of entries that weren't affected by the current operation.

[mofeiatwork]

it doesn't matter, bc the remove is safe even for non-existent partitions

[sonarcloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[github-actions]

[FE Incremental Coverage Report]

❌ fail : 13 / 29 (44.83%)

file detail

	path	covered_line	new_line	coverage	not_covered_line_detail
🔵	com/starrocks/catalog/RangePartitionInfo.java	13	29	44.83%	[267, 269, 277, 279, 280, 281, 282, 283, 284, 285, 286, 287, 417, 418, 420, 422]

[github-actions]

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

[github-actions]

@Mergifyio backport branch-3.3

[github-actions]

@Mergifyio backport branch-3.2

[mergify]

backport branch-3.3

✅ Backports have been created

• #45868 [BugFix] cleanup in-memory partition state if check fail when creating multiple-partitions (backport #45772) has been created for branch branch-3.3

[mergify]

backport branch-3.2

✅ Backports have been created

• #45869 [BugFix] cleanup in-memory partition state if check fail when creating multiple-partitions (backport #45772) has been created for branch branch-3.2