Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fix miss tokenization for standard parser when writing GIN and compatibility when downgrade and then upgrade #45813

Merged
merged 2 commits into from
May 17, 2024
Merged

[BugFix] Fix miss tokenization for standard parser when writing GIN and compatibility when downgrade and then upgrade #45813

merged 2 commits into from
May 17, 2024

Conversation

srlch
Copy link
Contributor

@srlch srlch commented May 17, 2024 •
edited by wyb

Fix two bug in this pr:

  1. Miss tokenization for standard parser when writing GIN.
  2. Fix NPE problem in hashCode when change version: v3.3->v3.2->v3.3

Fixes #44268

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@srlch srlch requested review from a team as code owners May 17, 2024 03:54
@mergify mergify bot assigned srlch May 17, 2024
@github-actions github-actions bot added the 3.3 label May 17, 2024
wyb
wyb previously approved these changes May 17, 2024
View reviewed changes
@wyb wyb enabled auto-merge (squash) May 17, 2024 04:46
srlch added 2 commits May 17, 2024 13:37
@srlch
[BugFix] Fix miss tokenization for standard parser when writing GIN a…
f021cdc 
…nd compatibility when downgrade and then upgrade

Fix two bug in this pr:
1. Miss tokenization for standard parser when writing GIN.
2. Fix NPE problem in hashCode when change version: v3.3->v3.2->v3.3

Signed-off-by: srlch <linzichao@starrocks.com>
@srlch
Fix case
d1f9762 
Signed-off-by: srlch <linzichao@starrocks.com>
auto-merge was automatically disabled May 17, 2024 05:40

Head branch was pushed to by a user without write access

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 17, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 1 / 1 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/catalog/Index.java 1 1 100.00% []

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 1 / 1 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/storage/inverted/clucene/clucene_inverted_writer.cpp 1 1 100.00% []

@wyb wyb merged commit c1c634e into StarRocks:main May 17, 2024
61 of 80 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label May 17, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented May 17, 2024 •
edited

backport branch-3.3

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request May 17, 2024
@srlch @mergify
[BugFix] Fix miss tokenization for standard parser when writing GIN a…
9eecbf4 
…nd compatibility when downgrade and then upgrade (#45813)

Signed-off-by: srlch <linzichao@starrocks.com>
(cherry picked from commit c1c634e)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/catalog/Index.java
@mergify mergify bot mentioned this pull request May 17, 2024
Closed
42 tasks
srlch added a commit to srlch/starrocks that referenced this pull request May 17, 2024
@srlch
[BugFix] Fix miss tokenization for standard parser when writing GIN a…
5cdeec0 
…nd compatibility when downgrade and then upgrade (StarRocks#45813)

Signed-off-by: srlch <linzichao@starrocks.com>
wyb pushed a commit that referenced this pull request May 17, 2024
@srlch
[BugFix] Fix miss tokenization for standard parser when writing GIN a…
52f7b31 
…nd compatibility when downgrade and then upgrade (backport #45813) (#45830)

Signed-off-by: srlch <linzichao@starrocks.com>
node pushed a commit to vivo/starrocks that referenced this pull request May 20, 2024
@srlch @node
[BugFix] Fix miss tokenization for standard parser when writing GIN a…
cfc4d89 
…nd compatibility when downgrade and then upgrade (StarRocks#45813)

Signed-off-by: srlch <linzichao@starrocks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyb wyb wyb approved these changes

@HangyuanLiu HangyuanLiu HangyuanLiu approved these changes

Assignees

@srlch srlch

Labels
3.3-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[inverted index]downgrade from 3.3 to 3.2, show create table, info is error
3 participants
@srlch @wyb @HangyuanLiu