Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to use XML and JSON based OMM elements. #3319

Draft
wants to merge 46 commits into
base: master
Choose a base branch
from

Conversation

A-j-K
Copy link
Contributor

@A-j-K A-j-K commented Jul 8, 2023

This is a work-in-progress PR

Description

  1. Update old 2008 SGP4 library to the latest 2020 version
  2. Add OMM object
  3. Add XML OMM reader
  4. Add JSON OMM reader
  5. Extend existing TLE to allow for XML-based OMM

Fixes #2458

Type of change

  • [n/a] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [n/a] Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update

How Has This Been Tested?

Unit tests will be added to cover some existing code and all new code.

Checklist:

  • My code follows the code style of this project.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (header file)
  • I have updated the respective chapter in the Stellarium User Guide
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@A-j-K A-j-K marked this pull request as draft July 8, 2023 22:38
@A-j-K
Copy link
Contributor Author

A-j-K commented Jul 8, 2023

@alex-w CodeFactor failed on imported SGP4 libs. How is this handled? I'm not keen on editing imported code. Can exceptions be added?

@alex-w
Copy link
Member

alex-w commented Jul 9, 2023

@alex-w CodeFactor failed on imported SGP4 libs. How is this handled? I'm not keen on editing imported code. Can exceptions be added?

See the log - it’s not critical

@alex-w alex-w added this to Needs triage in Plugin: Satellites via automation Jul 9, 2023
@gzotti
Copy link
Member

gzotti commented Jul 9, 2023

Looks like good progress!
For a cleaner history, it's better to occasionally rebase from master, not merge master into your work. This should be very easy if you are editing just a plugin while nobody else interferes.
Codefactor warns about cleaning up empty lines. Please adhere to these. For the "complex method" warnings, if there is no way to reduce complexity, we must accept that.

@A-j-K A-j-K changed the title WIP - Add ability to use XML based OMM elements. Add ability to use XML and JSON based OMM elements. Jul 12, 2023
@alex-w
Copy link
Member

alex-w commented Oct 18, 2023

Any news?

@github-actions github-actions bot added the has conflicts The pull request has conflicts label Dec 5, 2023
Copy link

github-actions bot commented Dec 5, 2023

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has conflicts The pull request has conflicts
Projects
Plugin: Satellites
  
Needs triage
Development

Successfully merging this pull request may close these issues.

Add support for OMM format for orbits of satellites
3 participants