Move some solar eclipse computations from AstroCalcDialog #3747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
10110111
force-pushed
the
eclipse-split-off
branch
from
33fee57
to
d88c63f
Compare
alex-w
added this to Needs triage
in Astronomical calculations (AstroCalc)
via automation
alex-w
requested changes
May 18, 2024
Astronomical calculations (AstroCalc)
automation
moved this from Needs triage
to In progress
May 18, 2024
|
The empty line at the end? Or is there some more? |
10110111
force-pushed
the
eclipse-split-off
branch
from
d88c63f
to
264d1fc
Compare
See CodeFactor report please |
10110111
force-pushed
the
eclipse-split-off
branch
from
264d1fc
to
998e4bc
Compare
alex-w
approved these changes
May 18, 2024
gzotti
reviewed
May 18, 2024
gzotti
approved these changes
May 18, 2024
10110111
force-pushed
the
eclipse-split-off
branch
from
998e4bc
to
bd1ffca
Compare
|
Let's wait until the CI finishes, after which, if successful, I'll merge. |
This reduces the size of AstroCalcDialog.cpp by 15% while localizing much of solar eclipse map generation and some other related computations in another file.
10110111
force-pushed
the
eclipse-split-off
branch
from
bd1ffca
to
af75ecd
Compare
alex-w
added
the
state: published
|
Hello @10110111! Please check the fresh version (development snapshot) of Stellarium: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the size of AstroCalcDialog.cpp by 15% while localizing much of solar eclipse map generation and some other related computations in another file.