Feature/flatten serialization #2056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
If a
Originally posted by @blythed in #2049 (comment) |
jieguangzhou
force-pushed
the
feature/flatten_serialization
branch
3 times, most recently
from
0799ec1
to
bafde5b
Compare
jieguangzhou
force-pushed
the
feature/flatten_serialization
branch
4 times, most recently
from
dd9bf63
to
95cec4e
Compare
blythed
reviewed
May 18, 2024
| return r | ||
|
|
||
| def delete_artifact(self, r: t.Dict): |
There was a problem hiding this comment.
I'm not really sure we need this method.
Since the artifacts and files are flat in Document.encode, we can
just directly with save_bytes, save_file.
There was a problem hiding this comment.
Not a big deal however - can be refactored later.
blythed
reviewed
May 18, 2024
| return current | ||
|
|
||
|
|
||
| def parse_query( |
There was a problem hiding this comment.
TODO: something with a != b, a == b, a >= b, a <= b etc..
blythed
reviewed
May 18, 2024
|
|
||
|
|
||
| # TODO: (New) remove the unused code | ||
| def _from_dict(r: t.Any, db: None = None) -> t.Any: |
blythed
reviewed
May 18, 2024
|
|
||
| def __repr__(self): | ||
| return '<EMPTY>' | ||
|
|
||
|
|
||
| class IntermidiaType: |
blythed
reviewed
May 18, 2024
| symbol_table = self.db[identifier] | ||
| symbol_table = symbol_table.relabel( | ||
| # TODO: Check for folds | ||
| {'output': identifier, '_fold': f'fold.{identifier}'} |
blythed
reviewed
May 18, 2024
There was a problem hiding this comment.
Looking very good, just a few things I would like to understand with @jieguangzhou and @kartik4949.
kartik4949
force-pushed
the
feature/flatten_serialization
branch
from
bb690fe
to
5e54403
Compare
blythed
force-pushed
the
feature/flatten_serialization
branch
from
5e54403
to
bb690fe
Compare
- Support table-level schema - Support unified query and insert methods - Support default field queries in Ibis
blythed
force-pushed
the
feature/flatten_serialization
branch
7 times, most recently
from
145c602
to
3bcb755
Compare
blythed
force-pushed
the
feature/flatten_serialization
branch
from
3bcb755
to
ad0f535
Compare
blythed
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
Checklist
make unit-testingandmake integration-testingsuccessfully?Additional Notes or Comments