-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PaymentRequest] Split the implementation and move it to appropriate bundles #15978
Draft
GSadee
wants to merge
77
commits into
Sylius:payment-request
Choose a base branch
from
GSadee:SYL-3376-split-payment-request-implementation
base: payment-request
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[PaymentRequest] Split the implementation and move it to appropriate bundles #15978
GSadee
wants to merge
77
commits into
Sylius:payment-request
from
GSadee:SYL-3376-split-payment-request-implementation
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
GSadee
commented
Mar 10, 2024
Q | A |
---|---|
Branch? | payment-request |
Bug fix? | no |
New feature? | no |
BC breaks? | no |
Deprecations? | no |
Related tickets | #15943 |
License | MIT |
…he related payment method deletion
This PR was merged into the payment-request branch. Discussion ---------- | Q | A | |-----------------|--------------------------------------------------------------| | Branch? | payment-request | | Bug fix? | no | | New feature? | yes | | BC breaks? | no | | Deprecations? | no | | Related tickets | Sylius#15502 | | License | MIT | Commits ------- Add Payment request model Add API resource Add first step of a PAYUM Capture request Finalise Payum POC and 1st try with no Payum using Offline payment method Rename data to payload Rename input/output data to requestPayload/responseData Move Payum stuff to PayumBundle Move services from ApiBundle to PaymentBundle Move services from ApiBundle to PayumBundle Update field in migration Add validation on adding payment request Behat api scenario for PayPal Attempt to get a real object instead of proxy one Pay with PayPal via authorize working Refactor some repeated processes and fix ECS 3/5 behat tests ok Behat ecs fix @paying_for_order&&@api fully working Fix PHPStan real issue and regenrate baseline for the rest Fix service definition and use state machine absctraction Move Payum related integrations to a dedicated folder Fix composer require checker missing new usages Regenerate baseline for PHP8.2 and Sf 6.4 Fix baseline Add missing deps Fix old ignore Use Sylius abstract doctrine migration to allow PostgreSQL Create migration for PostgreSQL Add missing messenger buses Refactor to use CoreBundle instead of SyliusPay(um|ment)Bundle
… config from the Core
Bunnyshell Preview Environment deployment failedCheck https://github.com/Sylius/Sylius/actions/runs/8224374599 for details. Available commands:
|
GSadee
force-pushed
the
SYL-3376-split-payment-request-implementation
branch
from
March 10, 2024 19:48
c7cdcf5
to
533c247
Compare
lchrusciel
force-pushed
the
payment-request
branch
from
April 8, 2024 09:45
e9f340c
to
202f77f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.