Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PaymentRequest] Split the implementation and move it to appropriate bundles #15978

Draft
wants to merge 77 commits into
base: payment-request
Choose a base branch
from

Conversation

GSadee
Copy link
Member

@GSadee GSadee commented Mar 10, 2024

Q A
Branch? payment-request
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets #15943
License MIT

Prometee and others added 24 commits March 3, 2024 14:36
Co-authored-by: Dmitri Perunov <diimpp@gmail.com>
Co-authored-by: Dmitri Perunov <diimpp@gmail.com>
Co-authored-by: Dmitri Perunov <diimpp@gmail.com>
This PR was merged into the payment-request branch.

Discussion
----------

| Q               | A                                                            |
|-----------------|--------------------------------------------------------------|
| Branch?         | payment-request                 |
| Bug fix?        | no                                                       |
| New feature?    | yes                                                       |
| BC breaks?      | no                                                       |
| Deprecations?   | no |
| Related tickets |        Sylius#15502               |
| License         | MIT                                                          |


Commits
-------
  Add Payment request model
  Add API resource
  Add first step of a PAYUM Capture request
  Finalise Payum POC and 1st try with no Payum using Offline payment method
  Rename data to payload
  Rename input/output data to requestPayload/responseData
  Move Payum stuff to PayumBundle
  Move services from ApiBundle to PaymentBundle
  Move services from ApiBundle to PayumBundle
  Update field in migration
  Add validation on adding payment request
  Behat api scenario for PayPal
  Attempt to get a real object instead of proxy one
  Pay with PayPal via authorize working
  Refactor some repeated processes and fix ECS
  3/5 behat tests ok
  Behat ecs fix
  @paying_for_order&&@api fully working
  Fix PHPStan real issue and regenrate baseline for the rest
  Fix service definition and use state machine absctraction
  Move Payum related integrations to a dedicated folder
  Fix composer require checker missing new usages
  Regenerate baseline for PHP8.2 and Sf 6.4
  Fix baseline
  Add missing deps
  Fix old ignore
  Use Sylius abstract doctrine migration to allow PostgreSQL
  Create migration for PostgreSQL
  Add missing messenger buses
  Refactor to use CoreBundle instead of SyliusPay(um|ment)Bundle
@GSadee GSadee added the DX Issues and PRs aimed at improving Developer eXperience. label Mar 10, 2024
@probot-autolabeler probot-autolabeler bot added the API APIs related issues and PRs. label Mar 10, 2024
Copy link

github-actions bot commented Mar 10, 2024

Bunnyshell Preview Environment deployment failed

Check https://github.com/Sylius/Sylius/actions/runs/8224374599 for details.

Available commands:

  • /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

@GSadee GSadee force-pushed the SYL-3376-split-payment-request-implementation branch from c7cdcf5 to 533c247 Compare March 10, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API APIs related issues and PRs. DX Issues and PRs aimed at improving Developer eXperience.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants