Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADR] Use Separate Base Form Types Instead of Type Extensions #16262

Merged
merged 1 commit into from
May 21, 2024

Conversation

TheMilek
Copy link
Member

@TheMilek TheMilek commented May 15, 2024

Q A
Branch? 1.14
Bug fix? no
New feature? no
BC breaks? no
License MIT

REF: #16257

@TheMilek TheMilek requested review from a team as code owners May 15, 2024 11:15
@probot-autolabeler probot-autolabeler bot added the Maintenance CI configurations, READMEs, releases, etc. label May 15, 2024
Rafikooo
Rafikooo previously approved these changes May 15, 2024
## References

* [Option 1 Example](https://github.com/Sylius/Sylius/pull/16257)
* [Option 2 Example](https://github.com/Sylius/Sylius/pull/15896)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this reference?

Copy link

github-actions bot commented May 15, 2024

Bunnyshell Preview Environment deleted

Available commands:

  • /bns:deploy to redeploy the environment

GSadee
GSadee previously approved these changes May 16, 2024
mpysiak
mpysiak previously approved these changes May 17, 2024
@GSadee GSadee changed the base branch from bootstrap-admin-panel to 2.0 May 20, 2024 09:31
@GSadee GSadee dismissed stale reviews from mpysiak, Rafikooo, and themself May 20, 2024 09:31

The base branch was changed.

@GSadee
Copy link
Member

GSadee commented May 20, 2024

The base of this pull-request was changed, you need fetch and reset your local branch
if you want to add new commits to this pull request. Reset before you pull, else commits
may become messed-up.

Unless you added new commits (to this branch) locally that you did not push yet,
execute git fetch origin && git reset "SYL-3522" to update your local branch.

Feel free to ask for assistance when you get stuck 👍

>
>
Co-authored-by: NoResponseMate jan.wojciech.goralski@gmail.com
@GSadee GSadee merged commit a0d8085 into Sylius:1.14 May 21, 2024
4 checks passed
@GSadee
Copy link
Member

GSadee commented May 21, 2024

Thanks, Kamil! 🥇

@TheMilek TheMilek deleted the SYL-3522 branch May 21, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance CI configurations, READMEs, releases, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants