Video Player

[DrRetro2033]

https://youtu.be/sWr5EN5hRI8
Added a simple video player for Tag Studio. Currently, the player will automatically mute itself when switching to another video. This is by design, as playing a really loud video before someone is ready will probably cause heart-attacks.

Also, I noticed the big refactor, and I am not fully familiar with the structure. I currently have VideoPlayer imported like this.

Could someone tell me the correct way of importing my video player in preview_panel.py? Thanks!

[yedpodtrzitko]

I dont have strong opinion about the feature itself, and it's not up to me to decide, but the README mentions the code should follow pep-8. That means the camelCases names in code should rather be snake_cases.

[DrRetro2033]

I dont have strong opinion about the feature itself, and it's not up to me to decide, but the README mentions the code should follow pep-8. That means the camelCases names in code should rather be snake_cases.

Alright, thanks for telling me.

[Loran425]

All good here

[Loran425]

I didn't think about the import order, if preview panel relies on video player, then the video player needs to be before the preview panel in the init file

Suggested change

	from .video_player import VideoPlayer
	from .video_player import VideoPlayer
	from .preview_panel import PreviewPanel

[Loran425]

Might want to change some of these logging.info calls to logging.debug call to avoid overwhelming the other terminal information.

[Loran425]

Suggested change

	from src.qt.widgets import (ThumbRenderer, FieldContainer, TagBoxWidget, TextWidget, PanelModal, EditTextBox,
	EditTextLine, ItemThumb)
	from .video_player import VideoPlayer
	from src.qt.widgets import (ThumbRenderer, FieldContainer, TagBoxWidget, TextWidget, PanelModal, EditTextBox,
	EditTextLine, ItemThumb, VideoPlayer)

Should just need to add VideoPlayer to the src.qt.widgets import on line 24-25

[DrRetro2033]

Tried that, but python gave me a circular dependency error.

[Loran425]

Tossed in another comment, I didn't think about import order, VideoPlayer needs to be imported in the __init__ file before PreviewPanel

[Loran425]

Code review aside, I'm leaning towards a thumbnail with a play button on it being the default and then clicking it starting the preview but I'm open to what the community wants, I'd just be worried about responsiveness in remote storage cases which might not be the typical setup.