-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Thumbrenderer #168
Refactor Thumbrenderer #168
Conversation
Overall this looks pretty good to me! The thumb renderer is about to be sort of a hot spot in the code with lots of activity (#171, #175, #179, #183, raw-image-previews, etc.), so while I'm open to an even larger refactor things will probably need to be done in smaller chunks over time after this PR. Consolidating the With all that being said, I'll be pulling #156 before this which refactors out all uses of |
- Change all instances of "os.path.normpath" to pathlib's "Path" - Remove unused import - Modify log formatting - Change "self.tr" to "self.thumb_renderer" to avoid masking internal method - Restore DecompressionBombError handling from main - Misc. formatting
Thanks for resolving the conflicts. i was just waiting for the os.paths pr to get merged and do it all in one big cleanup, haha. But i really appreciate the help. |
I refactored Thumbrenderer to remove duplicate code.
I merged the render and render_big methods into one _render method
I'm open to any suggestions and changes