Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Script for windows #78

Merged
merged 7 commits into from May 8, 2024
Merged

Build Script for windows #78

merged 7 commits into from May 8, 2024

Conversation

Thesacraft
Copy link
Collaborator

@Thesacraft Thesacraft commented Apr 28, 2024

Adds a build script for a windows executable
It intentionally doesn't hide the console for the exe because windows defender then complains that it is a malicious programm.
Also i oriented the build script of of the mac os build script from @williamtcastro

@Thesacraft Thesacraft changed the title Build Script windows Build Script for windows Apr 28, 2024
requirements.txt Outdated Show resolved Hide resolved
@Thesacraft
Copy link
Collaborator Author

So im considering to change --onefile to --onedir because this reduces the start process from 12s to under 2s but the disadvantage to that is that, we have a executable and a directory (and not just 1 file) that have to be in the same parent directory for it to work.
Maybe someone can give me input on this

I changed it to output an executable and a _internals dir because this makes it, atleast from my experience, much faster (12s -> 1-2s). This is probably because the decompression that has to happen before startup if its in one file
Copy link
Contributor

@williamtcastro williamtcastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its a great optiion to have a faster start but if is possible to run as a option for the user witch it could build either a portable one or a folder structure

@CyanVoxel CyanVoxel added the install/build tool A tool to help with installing, building, and/or launching the program label Apr 30, 2024
@CyanVoxel
Copy link
Member

So I was able to get it to build the .exe, but it won't launch and I get this error:

Error loading Python DLL 'F:\GitHub\TagStudio\build\TagStudio\_internal\python312.dll'.
LoadLibrary: The specified module could not be found.

I have no "_internal" folder inside the build directory. Is there something I should be doing differently?

@CyanVoxel
Copy link
Member

So I was able to get it to build the .exe, but it won't launch and I get this error:

Error loading Python DLL 'F:\GitHub\TagStudio\build\TagStudio\_internal\python312.dll'.
LoadLibrary: The specified module could not be found.

I have no "_internal" folder inside the build directory. Is there something I should be doing differently?

Ah, I needed to launch the .exe in the dist folder, not the build folder...

@CyanVoxel CyanVoxel merged commit 7ef2aa6 into TagStudioDev:main May 8, 2024
@Thesacraft
Copy link
Collaborator Author

Sorry i didn't answer. im currently learning for my A-Levels(or rather the german equivalent)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
install/build tool A tool to help with installing, building, and/or launching the program
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants