feat: add next power of 2 algorithm #193
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please merge it under hacktoberfest |
appgurueu
reviewed
Oct 16, 2023
| */ | ||
|
|
||
| export const findNextPowerOf2 = (n: number): number => { | ||
| n !== 0 ? n-- : n; |
There was a problem hiding this comment.
This should be written more readably as if (n !== 0) n--.
|
|
||
| describe("find next power of two", () => { | ||
| test.each([ | ||
| [0, 2], |
There was a problem hiding this comment.
This seems odd to me. Shouldn't the next power of two be 2⁰ = 1?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add an implementation to find the next power of 2 using bit manipulation