Add new func for returns the given fragmentStackIndex #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mucahidkambur
requested review from
MertNYuksel,
mucahidkambur and
bilgehankalkan
mucahidkambur
approved these changes
Dec 1, 2021
MertNYuksel
approved these changes
Dec 1, 2021
| @@ -158,6 +158,19 @@ open class MultipleStackNavigator( | |||
| initializeStackState() | |||
| } | |||
|
|
|||
| override fun reset(tabIndex: Int, fragmentStackIndex: Int) { | |||
There was a problem hiding this comment.
How about targetStackIndex rather than fragmentStackIndex?
| @@ -154,6 +154,13 @@ interface Navigator { | |||
| */ | |||
| fun initialize(savedState: Bundle?) | |||
|
|
|||
| /** | |||
| * Returns the given fragmentStackIndex in the given tabIndex | |||
There was a problem hiding this comment.
Can you please update the javadoc? I believe this was a copy paste mistake.
| } | ||
| fragmentManagerController.commitAllowingStateLoss() | ||
| fragmentManagerController.enableFragment(getCurrentFragmentTag()) | ||
| } |
There was a problem hiding this comment.
I believe we should handle else case too. We can call reset(tabIndex: Int, resetRootFragment: Boolean = true) to reset the tab or throw an exception. Which one do you think would be appropriate for your usecase?
bilgehankalkan
approved these changes
Dec 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
Added new function for returns the given fragmentStackIndex
Motivation and Context
In the step-by-step flows, user can want to return to one of the previous steps. With new function, we can return to the stack index in the tab we want.
How Has This Been Tested?
Added button to MainActivity for testing.
Screenshots (if appropriate):
Checklist: